add testing helper that checks diagnostic extra infos#38130
Merged
DanielMSchmidt merged 7 commits intomainfrom Feb 16, 2026
Merged
add testing helper that checks diagnostic extra infos#38130DanielMSchmidt merged 7 commits intomainfrom
DanielMSchmidt merged 7 commits intomainfrom
Conversation
DanielMSchmidt
added
the
no-changelog-needed
jbardin
reviewed
Feb 5, 2026
dbanck
previously approved these changes
Feb 13, 2026
dbanck
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far we don't check the diagnostic extras in our test cases, but some carry important information that we should verify.
I found this to be the most elegant solution since the extras we have inside our codebase are co-located to the function checking the diagnostics.
Fixes #
Target Release
1.15.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry