Skip to content

BE-427: Add hashql-macros crate with procedural macros for ID types and symbols #8495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
indietyp merged 15 commits into from
Feb 28, 2026

fix: suggestions from code review

b816f15
Select commit
Loading
Failed to load commit list.
Merged

BE-427: Add hashql-macros crate with procedural macros for ID types and symbols #8495

fix: suggestions from code review
b816f15
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 28, 2026 in 0s

63.04% (+0.01%) compared to ef314c5

View this Pull Request on Codecov

63.04% (+0.01%) compared to ef314c5

Details

Codecov Report

❌ Patch coverage is 62.96296% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.04%. Comparing base (ef314c5) to head (b816f15).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...hql/mir/src/pass/analysis/data_dependency/graph.rs 50.00% 4 Missing ⚠️
...cal/hashql/core/src/graph/algorithms/tarjan/mod.rs 0.00% 3 Missing ⚠️
libs/@local/hashql/core/src/id/slice.rs 0.00% 2 Missing ⚠️
libs/@local/hashql/core/src/module/mod.rs 0.00% 2 Missing ⚠️
...hashql/core/src/graph/algorithms/dominators/mod.rs 0.00% 1 Missing ⚠️
...l/hashql/core/src/graph/algorithms/tarjan/tests.rs 0.00% 1 Missing ⚠️
libs/@local/hashql/core/src/graph/mod.rs 50.00% 1 Missing ⚠️
libs/@local/hashql/core/src/graph/tests.rs 83.33% 1 Missing ⚠️
libs/@local/hashql/core/src/id/bit_vec/finite.rs 0.00% 1 Missing ⚠️
.../@local/hashql/core/src/id/bit_vec/matrix/tests.rs 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8495      +/-   ##
==========================================
+ Coverage   63.03%   63.04%   +0.01%     
==========================================
  Files        1302     1308       +6     
  Lines      132960   132855     -105     
  Branches     5509     5509              
==========================================
- Hits        83808    83756      -52     
+ Misses      48238    48185      -53     
  Partials      914      914

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov