-
Notifications
You must be signed in to change notification settings - Fork 119
FE-528: Fit Petrinaut zoom out to size of net #8611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
15625e5
Set petrinaut minZoom to be dynamically based on size of net
alex-e-leon 8e98f0a
Added changeset
alex-e-leon 922e1fb
When fitting minZoom in petrinaut handle the case where the net has nβ¦
alex-e-leon edc2ecc
Moved @types/lodash in petrinaut to dev dependency
alex-e-leon fcad400
Moved debounce + resize observer hooks to new util hook library
alex-e-leon bb7f3a7
Switch useDebounceCallback to use flush instead of cancel
alex-e-leon 4e6c960
Fix lint errors
alex-e-leon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@hashintel/petrinaut": minor | ||
| --- | ||
|
|
||
| Let minZoom be dynamically based on the size of the net |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
libs/@hashintel/petrinaut/src/views/SDCPN/hooks/util/use-debounce-callback.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import { debounce, type DebouncedFunc } from "lodash-es"; | ||
| import { useEffect, useMemo } from "react"; | ||
|
|
||
| // debounces a function, holding the debounced function between re-renders | ||
| // when unmounting, we flush any unresolved debounced calls when updating the debounced | ||
| // function or unmounting to avoid resolving on stale data or refs | ||
| export function useDebounceCallback< | ||
| // eslint-disable-next-line typescript-eslint/no-explicit-any | ||
| T extends (...args: any) => ReturnType<T>, | ||
| >(func: T, delay = 500): DebouncedFunc<T> { | ||
| const debounced = useMemo(() => debounce(func, delay), [func, delay]); | ||
|
|
||
| useEffect(() => { | ||
| return () => { | ||
| debounced.flush(); | ||
| }; | ||
| }, [func, delay]); | ||
|
|
||
| return debounced; | ||
| } |
19 changes: 19 additions & 0 deletions
19
libs/@hashintel/petrinaut/src/views/SDCPN/hooks/util/use-resize-observer.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import { useEffect, type RefObject } from "react"; | ||
|
|
||
| // sets up a resize observer on an element | ||
| export function useResizeObserver( | ||
| elementRef: RefObject<HTMLElement | null>, | ||
| func: (entries?: ResizeObserverEntry[]) => void, | ||
| ): void { | ||
| useEffect(() => { | ||
| if (elementRef.current) { | ||
| const resizeObserver = new ResizeObserver(func); | ||
|
|
||
| resizeObserver.observe(elementRef.current); | ||
|
|
||
| return () => { | ||
| resizeObserver.disconnect(); | ||
| }; | ||
| } | ||
| }, [elementRef, func]); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.