Open
Conversation
dpwiz
reviewed
Jan 17, 2026
src/DearImGui/Raw.hs
Outdated
| -- Return true when activated. The bool pointer will be updated to reflect the new state. | ||
| -- | ||
| -- Wraps @ImGui::MenuItem()@ with bool* parameter | ||
| menuItemBool :: (MonadIO m) => CString -> CString -> Ptr CBool -> m Bool |
Contributor
Author
There was a problem hiding this comment.
makes sense, done. thanks!
dpwiz
reviewed
Jan 18, 2026
src/DearImGui/Raw.hs
Outdated
Member
There was a problem hiding this comment.
Let's just drop the short one from raw, and make it take all 3 args.
The non-raw wrapper then can pass nulls there.
dpwiz
reviewed
Jan 18, 2026
src/DearImGui.hs
Outdated
| -> Maybe Text | ||
| -> Bool | ||
| -> m (Bool, Bool) | ||
| menuItemChecked label maybeShortcut isChecked = liftIO do |
Member
There was a problem hiding this comment.
Since this one picks up a shortcuts capability, please give it a proper intro too as menuItemEx. The original menuItem will stay as a shorthand, and this will give everything.
- Replace raw MenuItem bindings with a single full-parameter variant - Add menuItemEx to the high-level API - Keep menuItem and menuItemChecked as a shorthand wrapper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for menu items with checkmarks by exposing the
bool* p_selectedvariant of ImGui's
MenuItem()function.Changes
Raw API (
DearImGui.Raw)menuItemBool :: CString -> CString -> Ptr CBool -> m BoolHigh-level API (
DearImGui)menuItemBool :: Text -> Maybe Text -> Bool -> m (Bool, Bool)Example Usage
This enables proper checkable menu items as seen in the C++ demo.