Skip to content

new snapshot for stack build#4864

Merged
fendor merged 2 commits intohaskell:masterfrom
vidit-od:update_stack_snapshot
Mar 13, 2026
Merged

new snapshot for stack build#4864
fendor merged 2 commits intohaskell:masterfrom
vidit-od:update_stack_snapshot

Conversation

@vidit-od
Copy link
Collaborator

@vidit-od vidit-od commented Mar 9, 2026

Fixes #4696

This PR does :

  • remove ghc 9.6 stack build option
  • introduces ghc 9.10 stack build
  • fixes a few of the redundant imports that caused build problems.

this now enables us with 2 stack builds

  • Ghc 9.8 ( stack.yaml )
  • Ghc 9.10 ( stack-lts24.yaml )

@vidit-od vidit-od requested a review from fendor March 9, 2026 14:04
@vidit-od
Copy link
Collaborator Author

vidit-od commented Mar 9, 2026

Edit : I re-ran circleci failure and it passed this time.
Any reason for this flakyness ?

Original :
Regarding Stackage-lts23 failure.
Need some direction here on how to update the Stack version.

This is wrt ghc 9.8 version ( corresponding to stack.yaml )
The CircleCi logs say :

Warning: You are currently using Stack
         version 3.3.1 but version 3.9.3
         is available.
         
         You can try to upgrade by running
         stack upgrade
         
         Tired of seeing this? Add
         recommend-stack-upgrade: false
         to /root/.stack/config.yaml.

@fendor
Copy link
Collaborator

fendor commented Mar 11, 2026

@vidit-od I think we shouldn't bother too much with circle ci, let's get this merged and then migrate the circle ci jobs to github. We just need to be careful not overstretch our cache size.

@vidit-od
Copy link
Collaborator Author

vidit-od commented Mar 11, 2026

Edit :
ok i was wrong here, Flag tests do do a one more thing that makes them important. They test normal build & build with non default flags for all the ghc variants. There is no way to test the latter part using testing github actions.

below suggestion can be ignored :)

original :
@fendor makes sense;
i am not sure if this will help but we can also investigate about Flag tests on github maybe ?
although, i am not sure if it will have a significant ( or any ) form of cache relaxation

from what i understand, those tests are just for build checks only. we can delegate this to our Testing tests on github. The only extra thing these tests provide is : if any one fails all of the other flag tests gets cancelled.

thank you for reviewing the PR ;

Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments as well :)

@vidit-od
Copy link
Collaborator Author

@fendor , i tried to eliminate the conditional imports but i could not find any clean way to do that.
is there any way to ignore redundant import errors maybe ?

@fendor
Copy link
Collaborator

fendor commented Mar 13, 2026

Thanks, one CPP we can avoid, the others also already contain CPP, so it is fine.

@vidit-od vidit-od force-pushed the update_stack_snapshot branch 4 times, most recently from e7003b4 to 421d29c Compare March 13, 2026 12:47
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

discard ghc 9.6 stack build and introduce a new snapshot for ghc 9.10
change config files to remove references to lts22 and point to lts24 for new stack builds
@fendor fendor force-pushed the update_stack_snapshot branch from 421d29c to e64df34 Compare March 13, 2026 14:37
@fendor fendor enabled auto-merge (squash) March 13, 2026 14:37
@fendor fendor merged commit 73c0273 into haskell:master Mar 13, 2026
83 of 91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade stack*.yaml files

2 participants