Conversation
|
Edit : I re-ran circleci failure and it passed this time. Original : This is wrt ghc 9.8 version ( corresponding to |
|
@vidit-od I think we shouldn't bother too much with circle ci, let's get this merged and then migrate the circle ci jobs to github. We just need to be careful not overstretch our cache size. |
|
Edit : below suggestion can be ignored :) original : from what i understand, those tests are just for build checks only. we can delegate this to our Testing tests on github. The only extra thing these tests provide is : if any one fails all of the other flag tests gets cancelled. thank you for reviewing the PR ; |
fendor
left a comment
There was a problem hiding this comment.
Some comments as well :)
|
@fendor , i tried to eliminate the conditional imports but i could not find any clean way to do that. |
|
Thanks, one CPP we can avoid, the others also already contain CPP, so it is fine. |
e7003b4 to
421d29c
Compare
discard ghc 9.6 stack build and introduce a new snapshot for ghc 9.10
change config files to remove references to lts22 and point to lts24 for new stack builds
421d29c to
e64df34
Compare
Fixes #4696
This PR does :
ghc 9.6stack build optionghc 9.10stack buildthis now enables us with 2 stack builds
stack.yaml)stack-lts24.yaml)