Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive benchmark infrastructure to the iox library, including Makefile targets for running benchmarks and a suite of benchmarks covering core functionality.
Changes:
- Added Makefile with targets for running benchmarks (bench, bench-cpu, bench-mem), tests, and other development tasks
- Added benchmarks for Backoff operations (Duration, Block, Reset, SetBase, SetMax)
- Added benchmarks for semantic error helpers (IsSemantic, IsNonFailure, IsProgress, IsWouldBlock, IsMore)
- Added benchmarks for CopyPolicy with different policy types
- Added comparison benchmarks between iox.Copy and io.Copy
- Added benchmarks for chained TeeReader and TeeWriter operations
- Added benchmarks for deeply wrapped error classification
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Makefile | New file with development targets including test, bench, bench-cpu, bench-mem, vet, clean, and help |
| bench_test.go | Added comprehensive benchmark suite covering Backoff, semantic helpers, CopyPolicy, Copy comparison, TeeReader/TeeWriter chaining, and deep error wrapping |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
|
@hayabusa-cloud I've opened a new pull request, #18, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: hayabusa-cloud <81066232+hayabusa-cloud@users.noreply.github.com>
Fix bench-cpu and bench-mem targets: revert to single package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bench,bench-cpu,bench-mem)Test plan
make benchruns all benchmarksmake bench-cpugenerates cpu.out profilemake bench-memgenerates mem.out profile