fix: return ErrUnexpectedEOF on short copies#23
Merged
hayabusa-cloud merged 2 commits intomainfrom Feb 26, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a critical bug where CopyNPolicy and CopyNBufferPolicy violated the CopyN contract by returning (written, nil) instead of (written, io.ErrUnexpectedEOF) when unable to copy the requested n bytes. The fix also adds defensive handling for wrapped semantic errors in the write loop.
Changes:
- Added post-copy validation in
CopyNPolicyandCopyNBufferPolicyto returnio.ErrUnexpectedEOFwhenwritten < nand the error is nil or EOF - Added rollback handling for wrapped semantic errors in
copyBufferPolicywrite loop - Updated test expectations to assert the corrected
io.ErrUnexpectedEOFbehavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| io.go | Fixed CopyNPolicy and CopyNBufferPolicy to return io.ErrUnexpectedEOF on short copies; added defensive rollback for wrapped semantic errors in copyBufferPolicy |
| policy_test.go | Updated test names and assertions to expect io.ErrUnexpectedEOF on short copies |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CopyNPolicyandCopyNBufferPolicyreturned(written, nil)on short copies instead of(written, io.ErrUnexpectedEOF), diverging from theCopyN/CopyNBuffercontract.written < npost-check aftercopyBufferPolicyreturns.copyBufferPolicyslow-path write loop to checkIsSemantic(ew)withrollbackSeekerbefore the bare return.io.ErrUnexpectedEOFbehavior.