Update the ignore list of codecs for C++ and add missing type mappings [CTT-713]#557
Merged
ihsandemir merged 1 commit intohazelcast:masterfrom Oct 21, 2025
Merged
Conversation
ihsandemir
added a commit
to ihsandemir/hazelcast-cpp-client
that referenced
this pull request
Oct 20, 2025
…o use these codecs properly with the new introduced parameters. Associated protocol PR is hazelcast/hazelcast-client-protocol#557
ihsandemir
changed the title
Contributor
|
Could you add some more context on this PR please? |
Collaborator
Author
Added. Let me know you need more details. |
JackPGreen
reviewed
Oct 20, 2025
Contributor
I think it could be more detailed. I've raised some comments to check my understanding. |
JackPGreen
pushed a commit
to JackPGreen/hazelcast-cpp-client
that referenced
this pull request
Oct 20, 2025
…o use these codecs properly with the new introduced parameters. Associated protocol PR is hazelcast/hazelcast-client-protocol#557
JackPGreen
approved these changes
Oct 21, 2025
yuce
approved these changes
Oct 21, 2025
ihsandemir
added a commit
to hazelcast/hazelcast-cpp-client
that referenced
this pull request
Oct 21, 2025
Updated the codecs used with latest changes. Also, updated the code to use these codecs properly with the new introduced parameters. Associated protocol PR is hazelcast/hazelcast-client-protocol#557
gareth-johnston
pushed a commit
to gareth-johnston/hazelcast-client-protocol
that referenced
this pull request
Jan 14, 2026
…s [CTT-713] (hazelcast#557) Updated the ignore list of codecs for C++ and added missing type mappings. There were fields and some types added into some existing codecs e.g. authentication codec, and I had to update to handle them for C++ client. I added the type mapping for `Version` type. This is not used or exposed to user at all but it is a place holder really for now. I also replace the event 'nteger numbers to more meaningful enum names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the ignore list of codecs for C++ and added missing type mappings.
There were fields and some types added into some existing codecs e.g. authentication codec, and I had to update to handle them for C++ client.
I added the type mapping for
Versiontype. This is not used or exposed to user at all but it is a place holder really for now.I also replace the event 'nteger numbers to more meaningful enum names.