Encode since tag as string in yaml definition files#567
Merged
ihsandemir merged 2 commits intohazelcast:masterfrom Jan 22, 2026
Merged
Encode since tag as string in yaml definition files#567ihsandemir merged 2 commits intohazelcast:masterfrom
ihsandemir merged 2 commits intohazelcast:masterfrom
Conversation
… otherwise the yaml parser by default parses it as float and for example 2.10 is treated as 2.1, hence it results in incorrect versions. Surrounding the version with double quotes lets the yaml parser treat it as a string as expected by our generator.
emreyigit
approved these changes
Jan 21, 2026
yuce
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for since tag usage. We need to encode it as string in yaml file, otherwise the yaml parser by default parses it as float and for example 2.10 is treated as 2.1, hence it results in incorrect versions.
Surrounding the version with double quotes lets the yaml parser treat it as a string as expected by our generator.
I did find replace using regex.
replaced
since\: (\d+\.\d+\.\d+)with
since\: "$1"and replaced
since\: (\d+\.\d*)with
since\: "$1"doc update PR at here