Skip to content

page_iterator_sync is added. [API-1761]#1051

Merged
OzanCansel merged 6 commits intohazelcast:masterfrom
OzanCansel:API-1761
Mar 21, 2023
Merged

page_iterator_sync is added. [API-1761]#1051
OzanCansel merged 6 commits intohazelcast:masterfrom
OzanCansel:API-1761

Conversation

@OzanCansel
Copy link
Copy Markdown
Contributor

@OzanCansel OzanCansel commented Dec 16, 2022

  • page_iterator_sync is added.
  • pbegin(std::chrono::milliseconds) and pend() methods are added.
  • sql_page_iterator_sync example is added.

page_iterator_sync simply wraps page_iterator and behaves as syncronous iterator. It allows to define timeout for operations(it is required to prevent from infinite blocking).

@devOpsHazelcast
Copy link
Copy Markdown
Contributor

Windows test PASSed.

@devOpsHazelcast
Copy link
Copy Markdown
Contributor

Linux test PASSed.

1 similar comment
@devOpsHazelcast
Copy link
Copy Markdown
Contributor

Linux test PASSed.

@devOpsHazelcast
Copy link
Copy Markdown
Contributor

Windows test PASSed.

@ihsandemir ihsandemir modified the milestones: 5.2.0, 5.3.0 Feb 27, 2023
@devOpsHazelcast
Copy link
Copy Markdown
Contributor

Windows test PASSed.

@devOpsHazelcast
Copy link
Copy Markdown
Contributor

Linux test PASSed.

@OzanCansel OzanCansel force-pushed the API-1761 branch 3 times, most recently from accd69f to 2cf94f9 Compare March 14, 2023 14:04
@devOpsHazelcast
Copy link
Copy Markdown
Contributor

Linux test PASSed.

1 similar comment
@devOpsHazelcast
Copy link
Copy Markdown
Contributor

Linux test PASSed.

@devOpsHazelcast
Copy link
Copy Markdown
Contributor

Linux test FAILed.

1 similar comment
@devOpsHazelcast
Copy link
Copy Markdown
Contributor

Linux test FAILed.

@devOpsHazelcast
Copy link
Copy Markdown
Contributor

Windows test PASSed.

@devOpsHazelcast
Copy link
Copy Markdown
Contributor

Windows test PASSed.

@devOpsHazelcast
Copy link
Copy Markdown
Contributor

Linux test PASSed.

@OzanCansel OzanCansel changed the title sql_page_iterator_sync is added. page_iterator_sync and row_iterator_sync is added. [API-1761][API-1762] Mar 15, 2023
@OzanCansel OzanCansel force-pushed the API-1761 branch 3 times, most recently from 43662f7 to d752973 Compare March 15, 2023 06:00
@devOpsHazelcast
Copy link
Copy Markdown
Contributor

Linux test PASSed.

@devOpsHazelcast
Copy link
Copy Markdown
Contributor

Windows test PASSed.

@devOpsHazelcast
Copy link
Copy Markdown
Contributor

Windows test PASSed.

@devOpsHazelcast
Copy link
Copy Markdown
Contributor

Linux test PASSed.

@OzanCansel OzanCansel requested a review from akeles85 March 20, 2023 05:52
@devOpsHazelcast
Copy link
Copy Markdown
Contributor

Linux test PASSed.

@devOpsHazelcast
Copy link
Copy Markdown
Contributor

Windows test PASSed.

Copy link
Copy Markdown
Contributor

@akeles85 akeles85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some comments for requesting changes.

@devOpsHazelcast
Copy link
Copy Markdown
Contributor

Windows test PASSed.

@devOpsHazelcast
Copy link
Copy Markdown
Contributor

Linux test PASSed.

@OzanCansel OzanCansel merged commit 27cc1e6 into hazelcast:master Mar 21, 2023
OzanCansel added a commit to OzanCansel/hazelcast-cpp-client that referenced this pull request Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants