GenericRecord Feature has implemented. [API-1164][API-1853]#1086
Merged
OzanCansel merged 10 commits intohazelcast:masterfrom Mar 10, 2023
Merged
GenericRecord Feature has implemented. [API-1164][API-1853]#1086OzanCansel merged 10 commits intohazelcast:masterfrom
OzanCansel merged 10 commits intohazelcast:masterfrom
Conversation
Contributor
|
Linux test FAILed. |
Contributor
|
Windows test FAILed. |
Contributor
|
Linux test FAILed. |
Contributor
|
Windows test FAILed. |
Contributor
|
Linux test FAILed. |
Contributor
|
Linux test FAILed. |
Contributor
|
Windows test FAILed. |
Contributor
|
Linux test FAILed. |
Contributor
|
Windows test FAILed. |
OzanCansel
changed the title
Contributor
|
Linux test FAILed. |
Contributor
|
Windows test FAILed. |
OzanCansel
changed the title
OzanCansel
changed the title
Contributor
|
Linux test FAILed. |
OzanCansel
changed the title
Contributor
|
Windows test FAILed. |
Contributor
|
Linux test FAILed. |
Contributor
|
Windows test FAILed. |
ihsandemir
requested changes
Mar 8, 2023
hazelcast/include/hazelcast/client/serialization/generic_record_builder.h
Show resolved
Hide resolved
hazelcast/include/hazelcast/client/serialization/generic_record_builder.h
Outdated
Show resolved
Hide resolved
hazelcast/include/hazelcast/client/serialization/generic_record_builder.h
Outdated
Show resolved
Hide resolved
hazelcast/include/hazelcast/client/serialization/pimpl/compact/compact.h
Show resolved
Hide resolved
hazelcast/include/hazelcast/client/serialization/generic_record_builder.h
Outdated
Show resolved
Hide resolved
akeles85
previously approved these changes
Mar 8, 2023
…de more explanatory.
Contributor
|
Linux test PASSed. |
1 similar comment
Contributor
|
Linux test PASSed. |
Contributor
|
Windows test PASSed. |
ihsandemir
requested changes
Mar 9, 2023
Comment on lines
+933
to
+938
| if (already_built_) { | ||
| BOOST_THROW_EXCEPTION(exception::hazelcast_serialization{ | ||
| boost::str(boost::format("Illegal to write after record is " | ||
| "built. {field : %1%, kind : %2%}") % | ||
| field_name % kind) }); | ||
| } |
Collaborator
There was a problem hiding this comment.
Is this missing for Java client? If so, can you send a PR to Java as well.
Contributor
Author
There was a problem hiding this comment.
I remembered, it doesn't exist in Java. It needs to be implemented first at Java side. Do you want me to open an issue for it ?
hazelcast/include/hazelcast/client/serialization/generic_record_builder.h
Show resolved
Hide resolved
Contributor
|
Windows test FAILed. |
Contributor
|
Linux test PASSed. |
Contributor
|
Windows test FAILed. |
Contributor
|
Linux test PASSed. |
Contributor
|
Windows test PASSed. |
Contributor
|
Linux test PASSed. |
Contributor
|
Linux test PASSed. |
Contributor
|
Windows test PASSed. |
ihsandemir
previously approved these changes
Mar 10, 2023
| field_kind get_field_kind(const std::string& field_name) const; | ||
|
|
||
| /** | ||
| * @param fieldName the name of the field |
Collaborator
There was a problem hiding this comment.
Suggested change
| * @param fieldName the name of the field | |
| * @param field_name the name of the field |
| } | ||
|
|
||
| generic_record_builder::generic_record_builder( | ||
| std::shared_ptr<pimpl::schema> boundary, |
Collaborator
There was a problem hiding this comment.
Suggested change
| std::shared_ptr<pimpl::schema> boundary, | |
| std::shared_ptr<pimpl::schema> record_schema, |
Contributor
|
Windows test PASSed. |
Contributor
|
Linux test PASSed. |
ihsandemir
approved these changes
Mar 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr is based on
API-1327branch. So a user which only wants to see changes related this PR must do a diff toAPI-1327branch.generic_record_builderclass is added.generic_recordclass is added.generic_record, schema distribution, serialization etc. are implemented.generic_record.constoverloads of methods are added ingeneric_record. For low memory footprint types, it returns by value. For others it returnsconst T&.non-constmethod overloads ofgeneric_record, it allows to modify the value via reference.generic_recordgeneric_recordis copyable and movable.generic_record_builderis both movable and copyable, in case it is moved, the moved from object is left at invalid state and not usable.For detailed explanation look attached TDD to API-1853