Skip to content

ClientQueueTest.testRemainingCapacity is fixed. [API-1810]#1103

Merged
OzanCansel merged 2 commits intohazelcast:masterfrom
OzanCansel:API-1810
Feb 23, 2023
Merged

ClientQueueTest.testRemainingCapacity is fixed. [API-1810]#1103
OzanCansel merged 2 commits intohazelcast:masterfrom
OzanCansel:API-1810

Conversation

@OzanCansel
Copy link
Copy Markdown
Contributor

@OzanCansel OzanCansel commented Feb 22, 2023 •
edited
Loading

  • Futures weren't waited so it makes the test flaky and error-prone. Fixed by waiting.

Closes #1072

@OzanCansel OzanCansel added this to the 5.2.0 milestone Feb 22, 2023
@OzanCansel OzanCansel self-assigned this Feb 22, 2023
@devOpsHazelcast
Copy link
Copy Markdown
Contributor

devOpsHazelcast commented Feb 22, 2023

Windows test PASSed.

@devOpsHazelcast
Copy link
Copy Markdown
Contributor

devOpsHazelcast commented Feb 22, 2023

Linux test PASSed.

@devOpsHazelcast
Copy link
Copy Markdown
Contributor

devOpsHazelcast commented Feb 23, 2023

Windows test PASSed.

@devOpsHazelcast
Copy link
Copy Markdown
Contributor

devOpsHazelcast commented Feb 23, 2023

Linux test PASSed.

@OzanCansel OzanCansel merged commit eb14467 into hazelcast:master Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ihsandemir ihsandemir ihsandemir approved these changes

+1 more reviewer

@akeles85 akeles85 akeles85 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@OzanCansel OzanCansel

Labels

Type: Test-Failure

Projects

None yet

Milestone

5.2.0

Development

Successfully merging this pull request may close these issues.

ClientQueueTest.testRemainingCapacity occasionally fails on github actions. [API-1810]

4 participants

@OzanCansel @devOpsHazelcast @ihsandemir @akeles85