connection_manager_translate tests are fixed.#1123
Merged
OzanCansel merged 3 commits intohazelcast:masterfrom Feb 28, 2023
Merged
connection_manager_translate tests are fixed.#1123OzanCansel merged 3 commits intohazelcast:masterfrom
connection_manager_translate tests are fixed.#1123OzanCansel merged 3 commits intohazelcast:masterfrom
Conversation
Contributor
|
Windows test PASSed. |
Contributor
|
Linux test PASSed. |
Contributor
|
Windows test PASSed. |
akeles85
approved these changes
Feb 28, 2023
Contributor
|
Linux test PASSed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IP used in translate tests were
192.168.0.1but I observed that sometimes it connects to it, probably other github runners hosted in the192.168.0.1network. So I changed the url to some reserved multicast ip blocks.