Skip to content

Python extension - #32

Merged
hbf merged 6 commits into
hbf:masterfrom
adamheins:python-extension
Jan 23, 2022
Merged

hbf merged 6 commits into
hbf:masterfrom
adamheins:python-extension

Conversation

@adamheins

@adamheins adamheins commented Jan 22, 2022 •

Copy link
Copy Markdown
Contributor

This is a proposal for changing the Python bindings such that they're written as a C++ extension, one benefit of which is that it can be installed in the usual way with python setup.py install (and thus can be readily included in other projects without copying code). I've matched the API from the original implementation, and the tests are the same except for the type of exception raised for passing the wrong argument.

Let me know if you think this would be a useful change. I'm happy to make any changes to this code, and if we decide to go forward with this PR I can clean up the commit history before merging.

@hbf hbf left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamheins Thanks for the contribution! Great catch also spotting and removing unnecessary Python dependencies.

Comment thread python/setup.py Outdated
version="1.0",
description="Library to find the smallest enclosing ball of points",
author="Martin Kutz",
author_email="kutz@math.fu-berlin.de",

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the author to Kaspar Fischer, Bernd Gärtner, and Martin Kutz; as for the email, Martin Kutz is sadly not with us anymore so I suggest to remove it (the URL points to this GitHub project, which should be a good way to get help).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@hbf

hbf commented Jan 22, 2022

Copy link
Copy Markdown
Owner

I'm happy to make any changes to this code, and if we decide to go forward with this PR I can clean up the commit history before merging.

FYI I switched the project settings to only offer “Squash and merge”.

@hbf
hbf merged commit c279746 into hbf:master Jan 23, 2022
@hbf

hbf commented Jan 23, 2022

Copy link
Copy Markdown
Owner

Thanks again. Happy to add you also to the README if you’d like that, feel free to make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants