Repository navigation
Updated example.c to work with newer versions of g++ - #38
Merged
Merged
Conversation
Owner
|
Thanks for the fix, @janbridley. If you'd like to be mentioned in the contributors section (https://github.com/hbf/miniball#authors--acknowledgements), feel free to submit a PR. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As in #37, example.c cannot be compiled as written on g++ versions 10 or newer. The following error results from attempting to compile the script:
A very similar error is raised on x86-64 linux systems as well. The change proposed in 7532079 works for g++-11, g++-12, g++-13, and g++-14 on macOS arm64 and g++-10 on Red Hat linux x86-64.
The line
#include "Seb_debug.h"is not required for proper function on any of the versions of g++ tested, but has been left in to improve backwards compatibility.