Skip to content

[setting:set] Fix reload language when set. #1867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmolivas merged 4 commits into from
Feb 4, 2016
Merged

[setting:set] Fix reload language when set. #1867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
061f8af
[setting:set] Fix language reload when set.
jmolivas Feb 4, 2016
54a1524
[setting:set] Fix merge conflicts.
jmolivas Feb 4, 2016
62cb5c0
[setting:set] Apply PSR2 fixes.
jmolivas Feb 4, 2016
b804227
[setting:set] Add new end line.
jmolivas Feb 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/translations/en/settings.set.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ messages:
error-parsing: 'An error occurs during parsing of YAML file "%s".'
error-generating: 'Error setting new language in config file.'
error-writing: 'Error writing config file.'
success: 'Setting %s was set to %s for Drupal Console'
success: 'Setting %s was set to %s'
2 changes: 1 addition & 1 deletion config/translations/es/settings.set.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ messages:
error-parsing: 'An error occurs during parsing of YAML file "%s".'
error-generating: 'Error setting new language in config file.'
error-writing: 'Error writing config file.'
success: 'Setting %s was set to %s for Drupal Console'
success: 'Configuración %s fué actualizada a %s'
2 changes: 1 addition & 1 deletion src/Command/AboutCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ protected function execute(InputInterface $input, OutputInterface $output)

$commands = [
'init' => [
$this->trans('commands.init.description'),
$this->trans('commands.settings.init.description'),
'drupal init --override'
],
'quick-start' => [
Expand Down
4 changes: 4 additions & 0 deletions src/Command/Settings/SetCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,10 @@ protected function execute(InputInterface $input, OutputInterface $output)

$config->setConfigValue($parents, $settingValue);

if ($settingName == 'language') {
$this->getTranslator()->loadResource($settingValue, $application->getDirectoryRoot());
}

$io->success(
sprintf(
$this->trans('commands.settings.set.messages.success'),
Expand Down
3 changes: 1 addition & 2 deletions src/Command/Test/RunCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
$io->info($this->trans('commands.test.run.messages.phpunit-pending'));
return;
} else {

if(!class_exists($testClass)) {
if (!class_exists($testClass)) {
$io->error(
sprintf(
$this->trans('commands.test.run.messages.invalid-class'),
Expand Down