Skip to content

PR for #2845#2846

Merged
jmolivas merged 1 commit into
hechoendrupal:masterfrom
novia713:2845_module_download
Nov 1, 2016
Merged

PR for #2845#2846
jmolivas merged 1 commit into
hechoendrupal:masterfrom
novia713:2845_module_download

Conversation

@novia713
Copy link
Copy Markdown
Contributor

«Please, choose a 'module_name' version»
instead of
«Please, choose a… Packagist Drupal version»

@enzolutions
Copy link
Copy Markdown
Contributor

@novia713 the PR print it's empty, something goes wrong

@novia713
Copy link
Copy Markdown
Contributor Author

i can see the 2 lines changed sent in 34839c9 commit at
34839c9#diff-7cbb34adace2b68f456600f122f6a0a3R190

(i think Github represents badly the indentation, i think in code indentation is right. check it anyway)

PRs for translations of this string are at:
hechoendrupal/drupal-console-en#24
hechoendrupal/drupal-console-es#3

$this->trans('commands.site.new.questions.composer-release'),
sprintf(
$this->trans(
'commands.site.new.questions.composer-release'),
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enzolutions these are the 4 lines changes.
this PR only affects to this file src/Command/Module/DownloadCommand.php

@jmolivas
Copy link
Copy Markdown
Member

jmolivas commented Nov 1, 2016

@enzolutions at the beginning I saw the same
https://github.com/novia713/DrupalConsole/blob/34839c96e479c77db180e9eccca48fa143c6a0c1/src/Command/Module/DownloadCommand.php#L187-L194

Is not empty is just over-indented (we can fix that with the code fixer) until we implement travis to check the PR again.

@jmolivas jmolivas merged commit 6256db8 into hechoendrupal:master Nov 1, 2016
@jmolivas
Copy link
Copy Markdown
Member

jmolivas commented Nov 1, 2016

@novia713 Thanks for your contribution, your PR was merged. This will be included on the next release.

@jmolivas jmolivas added this to the 1.0.0-rc7 milestone Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants