Include TranslationRevertRoute only when content entity is translatable#2932
Merged
Conversation
Contributor
|
Just faced this issue, I can confirm that this patch would work as I only had to remove the following lines to get rid of theses errors : |
Member
|
@plopesc Thanks for your contribution, your PR was merged. This will be included on the next release. |
bpresles
pushed a commit
to bpresles/DrupalConsole
that referenced
this pull request
Dec 11, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getRevisionTranslationRevertRoute() method is included only in content entities when the revisionable entity is marked as translatable.
However, the method is called always when the entity type is marked as revisionable.
This throws the error below:
That's why I'm proposing here to add an extra check and call that method and create the route only when the entity type is revisonable AND translatable.
Thanks for your efforts