[BUGFIX 2581] Ensure AnnotationRegistry::registerLoader is correctly …#2946
Merged
Conversation
jmolivas
reviewed
Nov 18, 2016
| ->get('application.commands.aliases')?:[]; | ||
|
|
||
| foreach ($consoleCommands as $name) { | ||
| // Some commands call AnnotationRegistry::reset, we need to ensure that |
Member
There was a problem hiding this comment.
@mickaelperrin why is this inside the commands iteration?
Contributor
Author
There was a problem hiding this comment.
@jmolivas As I said previously, while debugging, I discovered that the registration of some commands call AnnotationRegistry::reset. If we want to ensure, that the Annotation is correctly set, we must ensure it is correctly defined before the beginning of the registration of a new command.
Member
|
@mickaelperrin Thanks for your contribution, your PR was merged. This will be included on the next release. |
bpresles
pushed a commit
to bpresles/DrupalConsole
that referenced
this pull request
Dec 11, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…defined