use on change to support ie and edge#28
Merged
hecrj merged 1 commit intohecrj:masterfrom May 23, 2019
stephenreddek:seelct-on-change-for-ie
Merged
use on change to support ie and edge#28hecrj merged 1 commit intohecrj:masterfrom stephenreddek:seelct-on-change-for-ie
hecrj merged 1 commit intohecrj:masterfrom
stephenreddek:seelct-on-change-for-ie
Conversation
Owner
|
Thank you! 🎉 We alrady have breaking changes in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both IE 11 and Edge don't support using the "input" event for select inputs. You have to use the "change" event. I wish this change didn't require a new direct dependency so that the version bump could be small. I couldn't think of a way to get around it though. I didn't mess with the json version requirement at all - I'm not sure what the best strategy is for picking the min dependency version.