Skip to content

Use vault/api module instead of vault #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
HnH wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use vault/api module instead of vault #81

HnH wants to merge 1 commit into from

Conversation

@HnH
Copy link

@HnH HnH commented Jan 9, 2020 •
edited
Loading

Purpose of this PR is to:

  1. Use the vault/api module, instead of vault itself.
  2. Update vault api lib version used in confita at the moment.
  3. Fix a situation with ambiguous import when a project requires both confita and vault/api modules, which happens now because confita locks vault version on v0.9.6 which depends on older api version.
go get github.com/hashicorp/vault/api: ambiguous import: found github.com/hashicorp/vault/api in multiple modules:
	github.com/hashicorp/vault v0.9.6 (/home/sergey/apps/go/pkg/mod/github.com/hashicorp/vault@v0.9.6/api)
	github.com/hashicorp/vault/api v1.0.4 (/home/sergey/apps/go/pkg/mod/github.com/hashicorp/vault/api@v1.0.4)

@HnH HnH requested a review from rogpeppe February 20, 2020 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rogpeppe rogpeppe Awaiting requested review from rogpeppe

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@HnH