Skip to content

deps: get rid of uhyve-interface dependency#64

Merged
mkroening merged 1 commit intohermit-os:mainfrom
fogti:no-uhyve-dep
Nov 17, 2025
Merged

deps: get rid of uhyve-interface dependency#64
mkroening merged 1 commit intohermit-os:mainfrom
fogti:no-uhyve-dep

Conversation

@fogti
Copy link
Contributor

@fogti fogti commented Nov 11, 2025

This required making the _Note structure generic over the length of the data.

This depends on #67.

@fogti fogti changed the title deps: get rid of uhyve-interface dependency deps: get rid of `uhyve-interface dependency Nov 11, 2025
@fogti fogti changed the title deps: get rid of `uhyve-interface dependency deps: get rid of uhyve-interface dependency Nov 11, 2025
Copy link
Member

@n0toose n0toose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the principle. The "cyclic dependency" factor felt "off" to me but I also felt it could be ignored initially - so I chose not to "challenge the status quo" there. In practice, it seems like this makes it just a little tiny bit harder (on top of many other mild inconveniences that quickly pile up) to update Uhyve's uhyve-interface and Uhyve itself: hermit-os/uhyve@b66ee70

@fogti fogti mentioned this pull request Nov 12, 2025
@fogti
Copy link
Contributor Author

fogti commented Nov 13, 2025

Fix-up due to #66.

@fogti fogti marked this pull request as draft November 13, 2025 18:43
@fogti fogti marked this pull request as ready for review November 13, 2025 18:49
@fogti fogti force-pushed the no-uhyve-dep branch 3 times, most recently from f3c30e3 to 48e3a7b Compare November 13, 2025 19:00
@fogti
Copy link
Contributor Author

fogti commented Nov 13, 2025

@mkroening Please take a look at this.

@fogti
Copy link
Contributor Author

fogti commented Nov 14, 2025

It would be nice if this could be merged before the next release and a new release published afterwards, as this stuff is still kinda delaying kernel development by making it particularly difficult to build hermit applications against a kernel with patched hermit-entry and uhyve-interface without having to massively patch the entire build process...

@fogti fogti force-pushed the no-uhyve-dep branch 3 times, most recently from 62cc464 to ac03827 Compare November 15, 2025 12:33
@fogti fogti requested a review from mkroening November 15, 2025 12:33
@fogti fogti force-pushed the no-uhyve-dep branch 2 times, most recently from d29a841 to b8aac5c Compare November 15, 2025 15:52
@fogti
Copy link
Contributor Author

fogti commented Nov 15, 2025

Split-off #68.

@mkroening mkroening force-pushed the no-uhyve-dep branch 2 times, most recently from 0d8bda5 to 6d30052 Compare November 17, 2025 13:13
This required making the _Note structure generic over the length of the data.
Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@mkroening mkroening added this pull request to the merge queue Nov 17, 2025
Merged via the queue into hermit-os:main with commit 1355587 Nov 17, 2025
4 checks passed
fogti added a commit to fogti/uhyve that referenced this pull request Nov 17, 2025
@fogti fogti deleted the no-uhyve-dep branch November 17, 2025 14:13
github-merge-queue bot pushed a commit to hermit-os/uhyve that referenced this pull request Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants