Conversation
Member
Author
|
CC: @stlankes, @jounathaen |
|
Do we need an upgradable RW lock? Why do you prefer this version? |
Member
Author
|
This lock is very small (1 usize) and very simple (stupid spinning on flags + backoff). I adapted it from We'll have to do benchmarks, but for scenarios with little contention I'd expect the more complex Upgradability and reentrancy come for free with this design. It's not something that we require at the moment, though. |
|
Ah, I oversaw also your PR cmnord/pflock#9 |
stlankes
approved these changes
Jan 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6.