feat(newlib): using kernel networking, instead of lwip#1237
Merged
mkroening merged 4 commits intohermit-os:mainfrom Jun 4, 2024
Merged
feat(newlib): using kernel networking, instead of lwip#1237mkroening merged 4 commits intohermit-os:mainfrom
mkroening merged 4 commits intohermit-os:mainfrom
Conversation
CarlWachter
changed the title
CarlWachter
force-pushed
the
no_lwip
branch
2 times, most recently
from
8bf9278 to
e21dcda
Compare
Contributor
Author
I cherry-picked the commits in question and everything still works 👍 |
mkroening
requested changes
May 31, 2024
Member
mkroening
left a comment
mkroening
left a comment
There was a problem hiding this comment.
I cherry-picked the commits in question and everything still works 👍
Awesome, could you remove the merge commit? :)
CarlWachter
force-pushed
the
no_lwip
branch
2 times, most recently
from
7ccf585 to
2708358
Compare
Contributor
Author
Done. I spent half an hour looking for it this morning, turns out i accidentally hit "Update branch" on Github and never pulled the change to my local, so i was searching for something that didn't exist :) |
CarlWachter
force-pushed
the
no_lwip
branch
3 times, most recently
from
2708358 to
58a2e3b
Compare
mkroening
approved these changes
Jun 3, 2024
Signed-off-by: Martin Kröning <martin.kroening@eonerc.rwth-aachen.de>
Signed-off-by: Martin Kröning <martin.kroening@eonerc.rwth-aachen.de>
mkroening
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapted cfg to now use kernel networking with newlib feature.
Closes #1165