fix(rsc): resolve self package from project root#845
Merged
hi-ogawa merged 3 commits intoMay 13, 2025
Conversation
Owner
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
hi-ogawa
commented
May 13, 2025
This reverts commit 6e13c6b.
hi-ogawa
changed the title
hi-ogawa
deleted the
05-13-fix_rsc_use_virtual_to_inject_self_package_import
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the issue when testing
@hiogawa/vite-rscon https://github.com/remix-run/react-router/tree/rsc. We get this error because "use client" transform injectsimport "@hiogawa/vite-rsc/rsc"to the files outside ofplayground/rsc-vite2, which in this case is linked deppackages/react-router/dist/development/index.mjs.By wrapping with virtual modules and redirect the resolution from root, it should be possible to support it.