fix: Fixed ContractServiceQueriesSimpleFeesTest suite to prevent flakyness#24704
Conversation
Signed-off-by: Eva <evdokia.georgieva@limechain.tech>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| CodeStyle | 2 minor |
🟢 Coverage ∅ diff coverage · 0.00% coverage variation
Metric Results Coverage variation ✅ 0.00% coverage variation (-1.00%) Diff coverage ✅ ∅ diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (0209d4d) 96503 78220 81.05% Head commit (8adb0ef) 96503 (+0) 78219 (-1) 81.05% (0.00%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#24704) 0 0 ∅ (not applicable) Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
TIP This summary will be updated as you push new changes. Give us feedback
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #24704 +/- ##
============================================
- Coverage 77.12% 77.11% -0.01%
+ Complexity 11702 11701 -1
============================================
Files 2492 2492
Lines 96600 96600
Branches 10698 10697 -1
============================================
- Hits 74499 74497 -2
- Misses 18330 18331 +1
- Partials 3771 3772 +1 see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
|
| Test | Ticket |
|---|---|
com.hedera.services.bdd.suites.file.FileCreateSuite#FetchFiles as written |
#24742 (🆕 New) |
Please review the linked tickets and determine if any of the new issues were caused by your changes.
Flaky Test(s) DetectedOne or more flaky tests were detected in this run. These tests have been reported before.
|
Description:
Refactored ContractServiceQueriesSimpleFeesTest to remove balance snapshot validations that caused flakiness in the invalid-contract precheck tests, replacing them with hasCostAnswerPrecheck assertions.
Added contractCallLocalZeroGasFails test to cover the gas lower-boundary precheck case.
Related issue(s):
Fixes #24703
Checklist