Skip to content

fix: Fixed ContractServiceQueriesSimpleFeesTest suite to prevent flakyness#24704

Merged
Evdokia-Georgieva merged 12 commits intomainfrom
contractServiceQueriesSimpleFeesTestRefactor
Apr 9, 2026
Merged

fix: Fixed ContractServiceQueriesSimpleFeesTest suite to prevent flakyness#24704
Evdokia-Georgieva merged 12 commits intomainfrom
contractServiceQueriesSimpleFeesTestRefactor

Conversation

@Evdokia-Georgieva
Copy link
Copy Markdown
Contributor

Description:
Refactored ContractServiceQueriesSimpleFeesTest to remove balance snapshot validations that caused flakiness in the invalid-contract precheck tests, replacing them with hasCostAnswerPrecheck assertions.
Added contractCallLocalZeroGasFails test to cover the gas lower-boundary precheck case.

Related issue(s):
Fixes #24703

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Eva <evdokia.georgieva@limechain.tech>
@Evdokia-Georgieva Evdokia-Georgieva added this to the v0.74 milestone Apr 2, 2026
@Evdokia-Georgieva Evdokia-Georgieva self-assigned this Apr 2, 2026
@trunk-io
Copy link
Copy Markdown

trunk-io bot commented Apr 2, 2026

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@lfdt-bot
Copy link
Copy Markdown

lfdt-bot commented Apr 2, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codacy-production
Copy link
Copy Markdown

codacy-production bot commented Apr 2, 2026

Not up to standards ⛔

🔴 Issues 2 minor

Alerts:
⚠ 2 issues (≤ 0 issues of at least minor severity)

Results:
2 new issues

Category Results
CodeStyle 2 minor

View in Codacy

🟢 Coverage ∅ diff coverage · 0.00% coverage variation

Metric Results
Coverage variation 0.00% coverage variation (-1.00%)
Diff coverage diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0209d4d) 96503 78220 81.05%
Head commit (8adb0ef) 96503 (+0) 78219 (-1) 81.05% (0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#24704) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

TIP This summary will be updated as you push new changes. Give us feedback

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@             Coverage Diff              @@
##               main   #24704      +/-   ##
============================================
- Coverage     77.12%   77.11%   -0.01%     
+ Complexity    11702    11701       -1     
============================================
  Files          2492     2492              
  Lines         96600    96600              
  Branches      10698    10697       -1     
============================================
- Hits          74499    74497       -2     
- Misses        18330    18331       +1     
- Partials       3771     3772       +1     

see 1 file with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Evdokia-Georgieva Evdokia-Georgieva marked this pull request as ready for review April 3, 2026 09:14
@Evdokia-Georgieva Evdokia-Georgieva requested a review from a team as a code owner April 3, 2026 09:14
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

⚠️ New Flaky Test(s) Detected — Action Required

New flaky tests were detected in this run. New tickets have been created and require your attention — please investigate whether the flakiness was introduced by changes in this PR.

Test Ticket
com.hedera.services.bdd.suites.file.FileCreateSuite#FetchFiles as written #24742 (🆕 New)

Please review the linked tickets and determine if any of the new issues were caused by your changes.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

Flaky Test(s) Detected

One or more flaky tests were detected in this run. These tests have been reported before.

Test Ticket
com.hedera.services.bdd.suites.validation.StreamValidationTest#streamsAreValid #24709

Copy link
Copy Markdown
Contributor

@joshmarinacci joshmarinacci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Evdokia-Georgieva Evdokia-Georgieva merged commit 1b44f88 into main Apr 9, 2026
64 of 65 checks passed
@Evdokia-Georgieva Evdokia-Georgieva deleted the contractServiceQueriesSimpleFeesTestRefactor branch April 9, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test flake: ContractServiceQueriesSimpleFeesTest > contract get info - invalid contract fails - no fee charged

4 participants