Skip to content

fix: HookStore leading zero cases#24762

Merged
andrewb1269 merged 9 commits intorelease/0.73from
r73-24729-hook-store-leading-zeros
Apr 9, 2026
Merged

fix: HookStore leading zero cases#24762
andrewb1269 merged 9 commits intorelease/0.73from
r73-24729-hook-store-leading-zeros

Conversation

@tinker-michaelj
Copy link
Copy Markdown
Contributor

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj tinker-michaelj requested review from a team as code owners April 6, 2026 14:42
@trunk-io
Copy link
Copy Markdown

trunk-io bot commented Apr 6, 2026

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@tinker-michaelj tinker-michaelj added this to the v0.73 milestone Apr 6, 2026
@tinker-michaelj tinker-michaelj self-assigned this Apr 6, 2026
@lfdt-bot
Copy link
Copy Markdown

lfdt-bot commented Apr 6, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@tinker-michaelj tinker-michaelj changed the base branch from main to release/0.73 April 6, 2026 14:43
@codacy-production
Copy link
Copy Markdown

codacy-production bot commented Apr 6, 2026

Not up to standards ⛔

🟢 Coverage 85.71% diff coverage · 0.00% coverage variation

Metric Results
Coverage variation 0.00% coverage variation (-1.00%)
Diff coverage 85.71% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f84c4a2) 94539 77714 82.20%
Head commit (98f9789) 94548 (+9) 77718 (+4) 82.20% (0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#24762) 21 18 85.71%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

TIP This summary will be updated as you push new changes. Give us feedback

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...vice/contract/impl/state/WritableEvmHookStore.java 78.57% 3 Missing ⚠️

Impacted file tree graph

@@                Coverage Diff                 @@
##             release/0.73   #24762      +/-   ##
==================================================
- Coverage           78.20%   78.20%   -0.01%     
  Complexity          11679    11679              
==================================================
  Files                2486     2486              
  Lines               94636    94645       +9     
  Branches            10210    10210              
==================================================
+ Hits                74012    74017       +5     
- Misses              16872    16877       +5     
+ Partials             3752     3751       -1     
Files with missing lines Coverage Δ Complexity Δ
...token/impl/handlers/transfer/TransferExecutor.java 90.38% <100.00%> (+0.14%) 50.00 <0.00> (ø)
...vice/contract/impl/state/WritableEvmHookStore.java 90.78% <78.57%> (-0.22%) 48.00 <0.00> (ø)

... and 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

petreze
petreze previously approved these changes Apr 6, 2026
Copy link
Copy Markdown
Contributor

@petreze petreze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

stoyanov-st
stoyanov-st previously approved these changes Apr 6, 2026
Copy link
Copy Markdown
Contributor

@stoyanov-st stoyanov-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming cherry-pick
LGTM

mhess-swl
mhess-swl previously approved these changes Apr 6, 2026
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj tinker-michaelj dismissed stale reviews from mhess-swl, stoyanov-st, and petreze via 1e47a54 April 7, 2026 16:55
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@andrewb1269 andrewb1269 merged commit 428ef3b into release/0.73 Apr 9, 2026
59 of 60 checks passed
@andrewb1269 andrewb1269 deleted the r73-24729-hook-store-leading-zeros branch April 9, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants