fix: HookStore leading zero cases#24762
Conversation
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Not up to standards ⛔🟢 Coverage
|
| Metric | Results |
|---|---|
| Coverage variation | ✅ 0.00% coverage variation (-1.00%) |
| Diff coverage | ✅ 85.71% diff coverage |
Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (f84c4a2) 94539 77714 82.20% Head commit (98f9789) 94548 (+9) 77718 (+4) 82.20% (0.00%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>
Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#24762) 21 18 85.71% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
TIP This summary will be updated as you push new changes. Give us feedback
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## release/0.73 #24762 +/- ##
==================================================
- Coverage 78.20% 78.20% -0.01%
Complexity 11679 11679
==================================================
Files 2486 2486
Lines 94636 94645 +9
Branches 10210 10210
==================================================
+ Hits 74012 74017 +5
- Misses 16872 16877 +5
+ Partials 3752 3751 -1
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
stoyanov-st
left a comment
There was a problem hiding this comment.
Confirming cherry-pick
LGTM
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
1e47a54
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Description:
HookStores inminimalKey()#24733