Skip to content

fix: Change the included submit message bytes from 1024 to 100 (#24505)#24780

Merged
andrewb1269 merged 1 commit intorelease/0.73from
cherry-pick-24505
Apr 9, 2026
Merged

fix: Change the included submit message bytes from 1024 to 100 (#24505)#24780
andrewb1269 merged 1 commit intorelease/0.73from
cherry-pick-24505

Conversation

@joshmarinacci
Copy link
Copy Markdown
Contributor

@joshmarinacci joshmarinacci commented Apr 6, 2026

(cherry picked from commit 6d945a3)

Description:

Cherry picks this PR to release 73.

It changes the included bytes for Submit Message from 1024 to 100, so that the cost will scale more cleanly. Messages with custom fees have a flat rate regardless of the number of bytes. Also changes the number of included processing bytes from 1024 to 1350 so that the top price for submit message is 0.008.

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@lfdt-bot
Copy link
Copy Markdown

lfdt-bot commented Apr 6, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codacy-production
Copy link
Copy Markdown

codacy-production bot commented Apr 6, 2026

Not up to standards ⛔

🟢 Coverage 100.00% diff coverage · +0.00% coverage variation

Metric Results
Coverage variation +0.00% coverage variation (-1.00%)
Diff coverage 100.00% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f5751fd) 94562 77747 82.22%
Head commit (a843c1b) 94564 (+2) 77752 (+5) 82.22% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#24780) 6 6 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

TIP This summary will be updated as you push new changes. Give us feedback

@joshmarinacci joshmarinacci self-assigned this Apr 6, 2026
@joshmarinacci joshmarinacci requested a review from a team as a code owner April 7, 2026 16:39
Signed-off-by: Josh Marinacci <joshua@marinacci.org>

(cherry picked from commit 6d945a3)
Signed-off-by: Josh Marinacci <joshua@marinacci.org>
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@               Coverage Diff               @@
##             release/0.73   #24780   +/-   ##
===============================================
  Coverage           78.22%   78.23%           
- Complexity          11680    11682    +2     
===============================================
  Files                2486     2486           
  Lines               94659    94661    +2     
  Branches            10213    10213           
===============================================
+ Hits                74050    74057    +7     
+ Misses              16862    16859    -3     
+ Partials             3747     3745    -2     
Files with missing lines Coverage Δ Complexity Δ
...alculator/ConsensusSubmitMessageFeeCalculator.java 100.00% <100.00%> (ø) 7.00 <0.00> (ø)

... and 16 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread hedera-node/configuration/mainnet/upgrade/simpleFeesSchedules.json
@akdev akdev added this to the v0.73 milestone Apr 9, 2026
@andrewb1269 andrewb1269 merged commit b5ecaf8 into release/0.73 Apr 9, 2026
118 of 124 checks passed
@andrewb1269 andrewb1269 deleted the cherry-pick-24505 branch April 9, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.