fix: Change the included submit message bytes from 1024 to 100 (#24505)#24780
Merged
andrewb1269 merged 1 commit intorelease/0.73from Apr 9, 2026
Merged
fix: Change the included submit message bytes from 1024 to 100 (#24505)#24780andrewb1269 merged 1 commit intorelease/0.73from
andrewb1269 merged 1 commit intorelease/0.73from
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Not up to standards ⛔🟢 Coverage
|
| Metric | Results |
|---|---|
| Coverage variation | ✅ +0.00% coverage variation (-1.00%) |
| Diff coverage | ✅ 100.00% diff coverage |
Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (f5751fd) 94562 77747 82.22% Head commit (a843c1b) 94564 (+2) 77752 (+5) 82.22% (+0.00%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>
Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#24780) 6 6 100.00% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
TIP This summary will be updated as you push new changes. Give us feedback
7ad0d4b to
2b82aca
Compare
Signed-off-by: Josh Marinacci <joshua@marinacci.org> (cherry picked from commit 6d945a3) Signed-off-by: Josh Marinacci <joshua@marinacci.org>
2b82aca to
a843c1b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## release/0.73 #24780 +/- ##
===============================================
Coverage 78.22% 78.23%
- Complexity 11680 11682 +2
===============================================
Files 2486 2486
Lines 94659 94661 +2
Branches 10213 10213
===============================================
+ Hits 74050 74057 +7
+ Misses 16862 16859 -3
+ Partials 3747 3745 -2
... and 16 files with indirect coverage changes 🚀 New features to boost your workflow:
|
akdev
approved these changes
Apr 8, 2026
rbarker-dev
approved these changes
Apr 8, 2026
aderevets
reviewed
Apr 8, 2026
aderevets
approved these changes
Apr 8, 2026
mhess-swl
approved these changes
Apr 8, 2026
stoyanov-st
approved these changes
Apr 9, 2026
steven-sheehy
approved these changes
Apr 9, 2026
Ferparishuertas
approved these changes
Apr 9, 2026
Nana-EC
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 6d945a3)
Description:
Cherry picks this PR to release 73.
It changes the included bytes for Submit Message from 1024 to 100, so that the cost will scale more cleanly. Messages with custom fees have a flat rate regardless of the number of bytes. Also changes the number of included processing bytes from 1024 to 1350 so that the top price for submit message is 0.008.
Related issue(s):
Fixes #
Notes for reviewer:
Checklist