Fix: Prevent color codes in output files#16
Fix: Prevent color codes in output files#16google-labs-jules[bot] wants to merge 2 commits intomainfrom
Conversation
This change prevents ANSI color codes from being written to output files. The `colored` crate is used to add color to the output. The mechanism to disable it for file output wasn't working as expected. This change fixes the issue by disabling the color override before the output is generated. This change also includes: - A new test case that writes colored text to a temporary file and asserts that the file does not contain any ANSI color codes. - A fix for the unrelated CLI test failures, which were caused by a timezone mismatch. - A fix for a related bug in `summary.rs` that was discovered while updating the tests.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
This change prevents ANSI color codes from being written to output files. The `colored` crate is used to add color to the output. The mechanism to disable it for file output wasn't working as expected. This change fixes the issue by disabling the color override before the output is generated. This change also includes: - A new test case that writes colored text to a temporary file and asserts that the file does not contain any ANSI color codes. - A new test case that asserts that the output to stdout contains ANSI color codes. - A fix for the unrelated CLI test failures, which were caused by a timezone mismatch. - A fix for a related bug in `summary.rs` that was discovered while updating the tests.
This change prevents ANSI color codes from being written to output files.
The
coloredcrate is used to add color to the output. The mechanism to disable it for file output wasn't working as expected. This change fixes the issue by disabling the color override before the output is generated.This change also includes:
summary.rsthat was discovered while updating the tests.PR created automatically by Jules for task 14334181072857013988 started by @hiqua