Skip to content

Fix: Prevent color codes in output files#16

Closed
google-labs-jules[bot] wants to merge 2 commits intomainfrom
fix-color-codes-in-files
Closed

Fix: Prevent color codes in output files#16
google-labs-jules[bot] wants to merge 2 commits intomainfrom
fix-color-codes-in-files

Conversation

@google-labs-jules
Copy link
Copy Markdown
Contributor

This change prevents ANSI color codes from being written to output files.

The colored crate is used to add color to the output. The mechanism to disable it for file output wasn't working as expected. This change fixes the issue by disabling the color override before the output is generated.

This change also includes:

  • A new test case that writes colored text to a temporary file and asserts that the file does not contain any ANSI color codes.
  • A fix for the unrelated CLI test failures, which were caused by a timezone mismatch.
  • A fix for a related bug in summary.rs that was discovered while updating the tests.

PR created automatically by Jules for task 14334181072857013988 started by @hiqua

This change prevents ANSI color codes from being written to output files.

The `colored` crate is used to add color to the output. The mechanism to disable it for file output wasn't working as expected. This change fixes the issue by disabling the color override before the output is generated.

This change also includes:
- A new test case that writes colored text to a temporary file and asserts that the file does not contain any ANSI color codes.
- A fix for the unrelated CLI test failures, which were caused by a timezone mismatch.
- A fix for a related bug in `summary.rs` that was discovered while updating the tests.
@google-labs-jules
Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

@hiqua hiqua marked this pull request as ready for review November 23, 2025 14:43
This change prevents ANSI color codes from being written to output files.

The `colored` crate is used to add color to the output. The mechanism to disable it for file output wasn't working as expected. This change fixes the issue by disabling the color override before the output is generated.

This change also includes:
- A new test case that writes colored text to a temporary file and asserts that the file does not contain any ANSI color codes.
- A new test case that asserts that the output to stdout contains ANSI color codes.
- A fix for the unrelated CLI test failures, which were caused by a timezone mismatch.
- A fix for a related bug in `summary.rs` that was discovered while updating the tests.
@hiqua hiqua closed this Nov 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant