Merged
Conversation
allan2
force-pushed
the
master
branch
2 times, most recently
from
a739668 to
425b612
Compare
Contributor
Author
|
This PR now passes all tests and is ready for review! More notes are in the commit messages. Feedback is very welcome. Cheers! |
hjr3
approved these changes
Dec 3, 2023
Fixes hjr3#24. hyper has its own IO traits. The dependency on tokio-io-timeout is dropped. Its types are implemented here, implementing hyper IO traits instead of tokio. - `tokio::io::AsyncRead` is switched to `hyper::rt::Read`, and AsyncWrite to `hyper::rt::Write`. - `tokio::io::AsyncSeek` is no longer needed. The wrapper type `TimeoutConnectorStream` that formerly wrapped tokio_io_timeout::TimeoutStream` is no longer needed. `tokio::io` has the handy AsyncReadExt and AsyncWriteExt traits, which were preivously used in tests. Now that we rely on Hyper IO, those had to be ported over: - AsyncReadExt -> ReadExt - AsyncWriteExt -> WriteExt - tokio internal Read -> ReadFut - tokio internal Write -> WriteFut
Owner
|
This looks great! Thank you for all your time and effort. |
Owner
|
https://crates.io/crates/hyper-timeout/0.5.0 - crates.io has been updated with the latest package |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for #24.
hyper now has its own IO traits.
This PR drops the dependency on tokio-io-timeout. Its types are now implemented here in this crate,
using hyper IO traits instead of tokio traits.
tokio::io::AsyncReadis switched tohyper::rt::Read, and AsyncWriteto Write
TimeoutConnectorStream, which wrapped tokio_io_timeout::TimeoutStream`, is removedThis PR is mostly finished, but I think it should be looked over. The tests that use
tokio::io::AsyncExtforreadare not fixed yet.