Skip to content

Patches for BbML#240

Merged
LPTK merged 19 commits intohkust-taco:hkmc2from
NeilKleistGao:bbml-fix🦼
Nov 25, 2024

Hidden character warning

The head ref may contain hidden characters: "bbml-fix\ud83e\uddbc"
Merged

Patches for BbML#240
LPTK merged 19 commits intohkust-taco:hkmc2from
NeilKleistGao:bbml-fix🦼

Conversation

@NeilKleistGao
Copy link
Member

@NeilKleistGao NeilKleistGao commented Nov 25, 2024

In this PR:

  • Remove unused components in BBCtx and fix related bugs
  • Use hint names for type variables if possible instead of using α everywhere
  • Fix metaprogramming pattern matching related problems
  • Fix predef type annotations and add missing operators
  • Update skolem extrusion
  • Rename bbml prelude file

Copy link
Contributor

@LPTK LPTK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Plz address my one comment and I'll merge.

In a follow-up PR, it would be good to generate human-readable type variable names, instead of ones that include counters. For this, I think you can directly reuse the codegen.js.Scope helper. It's not really specific to JS, so we could move it out of this js sub-package. OTOH type pretty-printing could be considered a form of codegen, so Scope can remain in codegen.

@NeilKleistGao NeilKleistGao marked this pull request as ready for review November 25, 2024 07:58
@NeilKleistGao
Copy link
Member Author

LGTM. Plz address my one comment and I'll merge.

In a follow-up PR, it would be good to generate human-readable type variable names, instead of ones that include counters. For this, I think you can directly reuse the codegen.js.Scope helper. It's not really specific to JS, so we could move it out of this js sub-package. OTOH type pretty-printing could be considered a form of codegen, so Scope can remain in codegen.

Good suggestions! I will track this in a new issue.

@LPTK LPTK merged commit efb66c1 into hkust-taco:hkmc2 Nov 25, 2024
@LPTK LPTK deleted the bbml-fix🦼 branch November 25, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants