Skip to content

Deforestation with nofibs in the Benchmark Sub-project#335

Closed
ychenfo wants to merge 405 commits intohkust-taco:hkmc2from
ychenfo:hkmc2-deforest-new
Closed

Deforestation with nofibs in the Benchmark Sub-project#335
ychenfo wants to merge 405 commits intohkust-taco:hkmc2from
ychenfo:hkmc2-deforest-new

Conversation

@ychenfo
Copy link
Member

@ychenfo ychenfo commented Sep 16, 2025 •
edited
Loading

TODO

  • Move nofibs to the benchmark subproject
  • Fix the paths

ychenfo added 30 commits March 27, 2025 20:04
@ychenfo
better names for fields of classes
d029daf
@ychenfo
update fixme tests
4ba1ea9
@ychenfo
tests output program despite of undefined var
a855c0f
@ychenfo
avoid creating needless match_rest functions
a666b60
@ychenfo
use extension method for resultId
8d8a83a
@ychenfo
update test: found code duplication; some problems are masked by chan…
b61ea2e 
…ges to avoid creating needless matchRest functions
@ychenfo
another duplication
7a3cb55
@ychenfo
fix for avoiding the previous duplication
f4c693f
@ychenfo
minor
f86dc2c
@ychenfo
use flatten to remove some dead code which contains free vars
f8c2fc5
@ychenfo
remove dead code which contains f.v.s in match rest
b648936
@ychenfo
return block unchanged instead of panic for unsupported cases
5194522
@ychenfo
wip: no need for two repl hosts
4b27f05
@ychenfo
better handling for noprod
0739bf6
@ychenfo
update test
8bcb753
@ychenfo
minor fix
a16a2b7
@ychenfo
fusion stats
31bc090
@ychenfo
improve jsbackenddiffmaker
0e68eec
@ychenfo
lessen output
2486b4d
@ychenfo
use locally; use data class
f75d2be
@ychenfo
cleanup jsbackenddiffmaker
b92abee
@ychenfo
better code: avoid local objects
3a47e3b
@ychenfo
tests from meeting
33f4703
@ychenfo
more comments
1553cc8
@ychenfo
wip: more needs to be done for things like id to block fusion
ca9a63f
@ychenfo
use of functions without defn now really blocks fusion
a3b4308
@ychenfo
more helpful deforestation debug output from tl.log
ce79cb5
@ychenfo
fresh type var for throw to avoid blocking fusion
f0c022c
@ychenfo
more recursive tests
0e96f9e
@ychenfo
zip unzip tests
418ee33
gok99
gok99 reviewed Oct 20, 2025
View reviewed changes
hkmc2Benchmarks/src/test/bench/nofibs2.mls
open Benchmark


:silent
Copy link
Contributor

@gok99 gok99 Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd forgotten to fix this in my PR, but these :silents could be moved to a single one in the header.

Copy link
Contributor

@LPTK LPTK Oct 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. @ychenfo pls address this.

@AnsonYeung AnsonYeung mentioned this pull request Feb 3, 2026
Closed
ychenfo added a commit to ychenfo/mlscript that referenced this pull request Feb 14, 2026
@ychenfo
fix mate
837e710 
hkust-taco#335 (comment)
LPTK pushed a commit that referenced this pull request Feb 16, 2026
@ychenfo
Add nofib tests to the benchmark sub-project (#394)
922ce6d 
* fix mate
#335 (comment)

* add nofibs to benchmarks

* update watcher path
@ychenfo ychenfo mentioned this pull request Mar 8, 2026
Merged
@ychenfo
Copy link
Member Author

ychenfo commented Mar 8, 2026

Superseded by #406

@ychenfo ychenfo closed this Mar 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LPTK LPTK LPTK left review comments

@AnsonYeung AnsonYeung AnsonYeung left review comments

@gok99 gok99 gok99 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ychenfo @LPTK @AnsonYeung @gok99