Instrumentation into Block IR

[ChingLongTin]

Call implementation will be after the algorithms for instrumenting functions are completed.

1. allocating optionNme
   This changed some diff tests (OpenWildcard.mls, Imports.mls, ImportMLs.mls) that imported Option themselves.
   If I allocate optionNme after checking if stageCode is enabled, it fails to link to the file.
   Is there some way to avoid changing the diff tests, or is this fine?

2. implementing I-Inst
   The current shape for Class C(n:s) includes the field names (n), but the field names are not available in Instantiation.
   The field names are used in sel. If the class is staged using I-Cls, then we can use the staged ClsLikeDefn to retrieve the symbol names, but when do we do when it isn't staged?

class A(a)
staged module B
  class C(a)
  fun f() = 
    new C(1) // ok, C is staged
    new A(1) // not ok, we don't know field names of A after instrumentation

[LPTK]

Somehow there is a compilation error...

[NeilKleistGao]

Functions with multiple parameter lists can be desugared by the first-class function transformer (Enabled by :ftc. Probably after #404 is merged).

[NeilKleistGao]

Some class symbols (e.g., generated by another pass) may have no defn, which will lead to a crash.

[ChingLongTin]

Since the parameters are necessary to reconstruct the class instance during specialization, this case throws a compiler error for now.

[NeilKleistGao]

I see. Then it is enough to raise a compilation error here. I will set a dummy definition with parameters in #404 so that our code can cooperate.

Is there any other information that you need to retrieve from the defn field?

[ChingLongTin]

From our discussions last time, we need paramsOpt and auxParams.

[NeilKleistGao]

OK. It seems that dummy definitions do not help either. I think a proper way is to have another pass before starting instrumentation to collect these locally generated classes (represented in block IR). If there is no definition for the class symbol, you try to retrieve it from the collected data. These generated classes are not visible outside the module, so when we access a class via the path, it should always be possible to find the defined defn field.

[LPTK]

@ChingLongTin are you going to follow @NeilKleistGao's suggestion in this PR? Or in a follow-up one?

[ChingLongTin]

I will do it in a follow-up one.

[ChingLongTin]

There's a diff test change on backlog/NamedArgs.mls, codegen/BasicTerms.mls, codegen/Do.mls, ucs/syntax/NestedOpSplits.mls, from the printing of the Predef symbol. For example in the first file we have the following diff:

diff --git a/hkmc2/shared/src/test/mlscript/backlog/NamedArgs.mls b/hkmc2/shared/src/test/mlscript/backlog/NamedArgs.mls
index e5e0724..4c99118 100644
--- a/hkmc2/shared/src/test/mlscript/backlog/NamedArgs.mls
+++ b/hkmc2/shared/src/test/mlscript/backlog/NamedArgs.mls
@@ -37,7 +37,7 @@ id(a: 0)
 //│   stats = Nil
 //│   res = App:
 //│     lhs = SynthSel{sym=member:id⁰}:
-//│       prefix = Ref{sym=member:Predef⁰} of member:Predef⁰
+//│       prefix = Ref{sym=member:Predef¹} of member:Predef¹
 //│       nme = Ident of "id"
 //│     rhs = Tup of Ls of 
 //│       Fld:

[LPTK]

@ChingLongTin, indeed, there was some flakiness that should be fixed now.

[LPTK]

Ok, LGTM, but please remember to address the two remaining comments in follow-up PRs.