Draft
Conversation
LPTK
reviewed
Mar 20, 2026
Comment on lines
+180
to
+189
| given Conversion[Int, NumIdx] with | ||
| def apply(index: Int): NumIdx = NumIdx(index) | ||
|
|
||
| /** A symbolic identifier. */ | ||
| case class SymIdx(val id: Str) extends Index: | ||
| def toWat: Document = doc"$$$id" | ||
|
|
||
| given Conversion[Str, SymIdx] with | ||
| def apply(id: Str): SymIdx = SymIdx(id) | ||
|
|
Contributor
There was a problem hiding this comment.
From the associated change, this is absolutely not worth it. You're shortening a couple of occurrences of SymIdx(x.nme) to x.nme but making everything more brittle and confusing in the process. Implicit conversions are to be avoided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.