Add support for addon update/install in background#177
Merged
Conversation
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add support for background addon install/update as added in home-assistant/supervisor#6134
As part of this work I realized that background actions should always use the default timeout. Previously something like addon install/update would run without a timeout because that action may take an indefinite amount of time. But when all the docker work is being done in the background it should have the normal timeout.
This second part also applies to backup/restore actions done in the background. We were always calling those APIs with
timeout=Nonebut that isn't appropriate when the action is being done in the background. Fixed that as well.