Reverse order of typing when multiple can match#38
Merged
Conversation
mdegat01
added
the
bugfix
agners
approved these changes
Dec 19, 2024
emontnemery
reviewed
Dec 19, 2024
Contributor
emontnemery
left a comment
emontnemery
left a comment
There was a problem hiding this comment.
The change looks good, but we might need a test also for FullBackupOptions?
emontnemery
approved these changes
Dec 20, 2024
Contributor
emontnemery
left a comment
emontnemery
left a comment
There was a problem hiding this comment.
LGTM, thanks @mdegat01 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Strings also pass the typing test for
list[str]orset[str]so typing order must be reversed to prevent incorrect parsing/serialization in any fields where both are accepted.