Fix #945 - Node.js v18 os.networkInterfaces()[].family number/string comparison

[oznu]

♻️ Current situation

nodejs/node#42787
nodejs/node#41431 (comment)

💡 Proposed solution

It's worth doing this sooner rather than later. There may be other compatibility issues in Node.js 18 we won't find until this one is patched.

The use of @ts-expect-error should alert us to remove the exception when @types/node is updated to 18 (if they decide to keep backwards compatibility with old versions, which they may not, be we need to).

Alternatively we could do something like this, but I feel like it will result in the exception never being removed in the future:

(info.family === "IPv6" || (info.family as unknown as string) === 6)

⚙️ Release Notes

• Fix an issue with network interface family detection when running Node.js 18

Testing

Tests are still failing on Node v18.0.0 - out of scope for this PR.

Reviewer Nudging

@Supereg

[coveralls]

Pull Request Test Coverage Report for Build 2227779606

• 2 of 4 (50.0%) changed or added relevant lines in 2 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.008%) to 51.819%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/lib/util/eventedhttp.ts	0	2	0.0%

Files with Coverage Reduction	New Missed Lines	%
src/lib/util/eventedhttp.ts	1	22.02%

Totals
Change from base Build 2212935693:	-0.008%
Covered Lines:	5712
Relevant Lines:	10069

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 2226464995

• 2 of 4 (50.0%) changed or added relevant lines in 2 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.08%) to 51.75%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/lib/util/eventedhttp.ts	0	2	0.0%

Files with Coverage Reduction	New Missed Lines	%
src/lib/util/eventedhttp.ts	1	22.02%

Totals
Change from base Build 2162410027:	-0.08%
Covered Lines:	5709
Relevant Lines:	10068

---

💛 - Coveralls

[bauer-andreas]

Thanks for addressing this. 👍🏼

Proposing to include this in the upcoming 0.10.2 release. I adopted the base branch accordingly.