homebridge-dolphin #635

Activity

1. nitaybz

   added

   pendingthe label given to a new verification/icon requestthe label given to a new verification/icon request

   on Dec 12, 2023
2. github-actions commented on Dec 12, 2023

   

   github-actionsBot

   on Dec 12, 2023 – with GitHub Actions

   Contributor

   More actions

   ✅ Pre-checks completed successfully.
3. bwp91

   added

   currently-reviewinguse for starting a review - adds a comment with the verification list with empty checkboxesuse for starting a review - adds a comment with the verification list with empty checkboxes

   and removed

   pendingthe label given to a new verification/icon requestthe label given to a new verification/icon request

   on Dec 14, 2023
4. github-actions commented on Dec 14, 2023

   

   github-actionsBot

   on Dec 14, 2023 – with GitHub Actions

   Last edited by bwp91

   Contributor

   More actions

   • General
     • The plugin must be of type dynamic platform.
     • The plugin must not offer the same nor less functionality than that of any existing verified plugin.
   • Repo
     • The plugin must be published to NPM and the source code available on a GitHub repository, with issues enabled.
     • A GitHub release should be created for every new version of your plugin, with release notes.
   • Environment
     • The plugin must run on all supported LTS versions of Node.js, at the time of writing this is Node v18 and v20.
     • The plugin must successfully install and not start unless it is configured.
     • The plugin must not execute post-install scripts that modify the users' system in any way.
     • The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
   • Codebase
     • The plugin must implement the Homebridge Plugin Settings GUI.
     • The plugin must not contain any analytics or calls that enable you to track the user.
     • If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.
     • The plugin must not throw unhandled exceptions, the plugin must catch and log its own errors.

   ---

   ---

   Comment /check to run checks again.
5. bwp91 commented on Dec 14, 2023

   

   bwp91

   on Dec 14, 2023

   Contributor

   More actions

   Happy to verify this, I just wonder if there is meant to be any logging if the entered username and password are incorrect? I have entered nonsense for the username and password, obviously incorrect, but there is no logging for "incorrect credentials".
6. bwp91

   added

   verifieduse when a plugin meets the criteria - adds the verified badge textuse when a plugin meets the criteria - adds the verified badge text

   and removed

   currently-reviewinguse for starting a review - adds a comment with the verification list with empty checkboxesuse for starting a review - adds a comment with the verification list with empty checkboxes

   on Dec 14, 2023
7. github-actions commented on Dec 14, 2023

   

   github-actionsBot

   on Dec 14, 2023 – with GitHub Actions

   Contributor

   More actions

   Congratulations! Your plugin has been verified.

   You can now add one of the Verified by Homebridge badges to your plugin's README:

   

   [![verified-by-homebridge](https://badgen.net/badge/homebridge/verified/purple)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)
   

   

   [![verified-by-homebridge](https://img.shields.io/badge/homebridge-verified-blueviolet?color=%23491F59&style=for-the-badge&logoColor=%23FFFFFF&logo=homebridge)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)
   

   Your plugin is now also eligible to display a ❤️ Donate button on its tile in the Homebridge UI. See https://github.com/homebridge/homebridge/wiki/Donation-Links for instructions.

   If for any reason in the future you can no longer maintain your plugin, please consider transferring it to our unmaintained plugins repo. We can take ownership until another willing developer comes along.

   Don't forget to join the official Homebridge Discord server, where plugin developers can get tips and advice from other developers and the Homebridge project team in the #plugin-development channel!

   Thank you for your contribution to the Homebridge Community.
   https://homebridge.io
8. bwp91

   added a commit that references this issue on Dec 14, 2023

   verify: homebridge-dolphin

   ...

   bd34816
9. bwp91 commented on Dec 14, 2023

   

   bwp91

   on Dec 14, 2023

   Contributor

   More actions

   icon added too :)
10. bwp91

    closed this as completedon Dec 14, 2023