Skip to content

Verification Request: homebridge-atomberg-fan #729

New issue
New issue
Closed
Closed
Verification Request: homebridge-atomberg-fan#729
Labels
verifieduse when a plugin meets the criteria - adds the verified badge text

Description

@shadow5688
shadow5688
opened on May 30, 2024

Plugin Name

homebridge-atomberg-fan

Link To GitHub Repo

https://github.com/Sangwan5688/homebridge-atomberg-fan

Plugin Icon (Optional)

No response

The plugin does not offer the same nor less functionality than that of any existing verified plugin.

🟢 Yes

The plugin successfully installs and does not start unless it is configured.

🟢 Yes

The plugin does not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.

🟢 Yes

The plugin does not contain any analytics or calls that enable you to track the user.

🟢 Yes

If the plugin needs to write files to disk (cache, keys, etc.), it stores them inside the Homebridge storage directory.

🟢 Yes

The plugin does not throw unhandled exceptions, the plugin must catch and log its own errors.

🟢 Yes

More Information

No response

Activity

  1. shadow5688
    added
    pendingthe label given to a new verification/icon request
    on May 30, 2024

  2. github-actions commented on May 30, 2024

    @github-actions
    github-actionsBot
    on May 30, 2024 – with GitHub Actions
    Contributor

    🔴 The following pre-checks failed:

    • GitHub Repo: should contain releases

    🟢 The following pre-checks passed:

    • Installation: successfully installed
    • Package JSON: homepage exists
    • Package JSON: bugs.url exists and seems a valid URL
    • Package JSON: keywords exist and contain 'homebridge-plugin'
    • Package JSON: 'preinstall' in scripts is not present
    • Package JSON: 'install' in scripts is not present
    • Package JSON: 'postinstall' in scripts is not present
    • Package JSON: engines.node property is compatible with Node 18
    • Package JSON: engines.node property is compatible with Node 20
    • Package JSON: engines.homebridge property is compatible with Homebridge 1.7.0
    • Package JSON: initializer function found
    • GitHub Repo: repository is public
    • GitHub Repo: repository is not archived
    • GitHub Repo: issues are enabled
    • NPM Package: has not been deprecated
    • Config Schema JSON: exists and is valid JSON
    • Config Schema JSON: contains a valid pluginAlias
    • Config Schema JSON: the pluginType is set to 'platform'
    • Config Schema JSON: contains a name schema property
    • Dependencies: homebridge was not installed as a dependency
    • Dependencies: hap-nodejs was not installed as a dependency

    ⚠️ Please action these failures and then comment /check to run the checks again. Let us know if you need any help.

    If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.

  3. github-actions
    added
    awaiting-changesuse after review has started - awaiting user to make changes to plugin
    and removed
    pendingthe label given to a new verification/icon request
    on May 30, 2024

  4. shadow5688 commented on May 30, 2024

    @shadow5688
    shadow5688
    on May 30, 2024
    Author

    /check

  5. github-actions
    added
    pendingthe label given to a new verification/icon request
    and removed
    awaiting-changesuse after review has started - awaiting user to make changes to plugin
    on May 30, 2024

  6. github-actions commented on May 30, 2024

    @github-actions
    github-actionsBot
    on May 30, 2024 – with GitHub Actions
    Contributor

    🟢 The following pre-checks passed:

    • Installation: successfully installed
    • Package JSON: homepage exists
    • Package JSON: bugs.url exists and seems a valid URL
    • Package JSON: keywords exist and contain 'homebridge-plugin'
    • Package JSON: 'preinstall' in scripts is not present
    • Package JSON: 'install' in scripts is not present
    • Package JSON: 'postinstall' in scripts is not present
    • Package JSON: engines.node property is compatible with Node 18
    • Package JSON: engines.node property is compatible with Node 20
    • Package JSON: engines.homebridge property is compatible with Homebridge 1.7.0
    • Package JSON: initializer function found
    • GitHub Repo: repository is public
    • GitHub Repo: repository is not archived
    • GitHub Repo: issues are enabled
    • GitHub Repo: contains releases
    • NPM Package: has not been deprecated
    • Config Schema JSON: exists and is valid JSON
    • Config Schema JSON: contains a valid pluginAlias
    • Config Schema JSON: the pluginType is set to 'platform'
    • Config Schema JSON: contains a name schema property
    • Dependencies: homebridge was not installed as a dependency
    • Dependencies: hap-nodejs was not installed as a dependency

    🎉 All pre-checks passed successfully, nice work! Your plugin and/or icon will now be manually reviewed by the Homebridge team.

  7. bwp91
    added
    currently-reviewinguse for starting a review - adds a comment with the verification list with empty checkboxes
    and removed
    pendingthe label given to a new verification/icon request
    on May 31, 2024

  8. github-actions commented on May 31, 2024

    @github-actions
    github-actionsBot
    on May 31, 2024 – with GitHub Actions
    Contributor
    • General
      • The plugin must be of type dynamic platform.
      • The plugin must not offer the same nor less functionality than that of any existing verified plugin.
    • Repo
      • The plugin must be published to NPM and the source code available on a GitHub repository, with issues enabled.
      • A GitHub release should be created for every new version of your plugin, with release notes.
    • Environment
      • The plugin must run on all supported LTS versions of Node.js, at the time of writing this is Node v18 and v20.
      • The plugin must successfully install and not start unless it is configured.
      • The plugin must not execute post-install scripts that modify the users' system in any way.
      • The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
    • Codebase
      • The plugin must implement the Homebridge Plugin Settings GUI.
      • The plugin must not contain any analytics or calls that enable you to track the user.
      • If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.
      • The plugin must not throw unhandled exceptions, the plugin must catch and log its own errors.

  9. bwp91 commented on May 31, 2024

    @bwp91
    bwp91
    on May 31, 2024
    Contributor

    Hi @Sangwan5688

    all good with verification criteria, a nice easy one, thank you!

    i will follow up with another comment after the message below ⬇️

  10. bwp91
    added
    verifieduse when a plugin meets the criteria - adds the verified badge text
    and removed
    currently-reviewinguse for starting a review - adds a comment with the verification list with empty checkboxes
    on May 31, 2024

  11. github-actions commented on May 31, 2024

    @github-actions
    github-actionsBot
    on May 31, 2024 – with GitHub Actions
    Contributor

    Congratulations! Your plugin has been verified!

    You can now add one of the Verified by Homebridge badges to your plugin's README:

    verified-by-homebridge

    [![verified-by-homebridge](https://badgen.net/badge/homebridge/verified/purple)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

    verified-by-homebridge

    [![verified-by-homebridge](https://img.shields.io/badge/homebridge-verified-blueviolet?color=%23491F59&style=for-the-badge&logoColor=%23FFFFFF&logo=homebridge)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

    Your plugin is now also eligible to display a ❤️ Donate button on its tile in the Homebridge UI. See https://github.com/homebridge/homebridge/wiki/Donation-Links for instructions.

    If for any reason in the future you can no longer maintain your plugin, please consider transferring it to our unmaintained plugins repo. We can take ownership until another willing developer comes along.

    Don't forget to join the official Homebridge Discord server, where plugin developers can get tips and advice from other developers and the Homebridge project team in the #plugin-development channel!

    As a verified plugin, you can request a channel in the Discord server to discuss your plugin with users and other developers. Just ask in the #plugin-development channel.

    Thank you for your contribution to the Homebridge community.

    • The Homebridge Team

  12. bwp91 commented on May 31, 2024

    @bwp91
    bwp91
    on May 31, 2024
    Contributor

    is it possible there is a slight issue with the logic?

    i have an incorrect API and refresh token in the config, and an initial message in the log shows that Login failed.

    However the next line then shows successfully logged in?

    Screenshot 2024-05-31 at 21 57 51

    Just thought i'd call this out! However small issues like this are nothing to do with a plugin being verified or not!

    Thanks

  13. bwp91
    added a commit that references this issue on May 31, 2024

    verify: homebridge-atomberg-fan

    6416acb

  14. shadow5688 commented on Jun 1, 2024

    @shadow5688
    shadow5688
    on Jun 1, 2024
    Author

    @bwp91 yes, I'm aware of that. This was even fixed day before yesterday, I still haven't published that though. The issue was that even if login fails next step of discovering devices was called. That also fails though, as there's no API token present. Anyways, It's already fixed now, I'll publish the new version soon.

  15. bwp91
    closed this as completedon Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    verifieduse when a plugin meets the criteria - adds the verified badge text

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions