Verification Request: homebridge-ecowitt-weather-sensors #758

Activity

1. rhockenbury

   added

   pendingthe label given to a new verification/icon requestthe label given to a new verification/icon request

   on Sep 15, 2024
2. github-actions commented on Sep 15, 2024

   

   github-actionsBot

   on Sep 15, 2024 – with GitHub Actions

   Contributor

   More actions

   🔴 The following checks failed:

   • Package JSON: homepage missing or does not start with https://
   • Config Schema JSON: does not contain a name schema property

   ---

   🟢 The following checks passed:

   • Installation: successfully installed
   • Package JSON: bugs.url exists and seems a valid URL
   • Package JSON: keywords exist and contain 'homebridge-plugin'
   • Package JSON: 'preinstall' in scripts is not present
   • Package JSON: 'install' in scripts is not present
   • Package JSON: 'postinstall' in scripts is not present
   • Package JSON: engines.node property is compatible with Node 18
   • Package JSON: engines.node property is compatible with Node 20
   • Package JSON: engines.homebridge property is compatible with Homebridge 1.8.4
   • Package JSON: initializer function found
   • GitHub Repo: repository is public
   • GitHub Repo: repository is not archived
   • GitHub Repo: issues are enabled
   • GitHub Repo: contains releases
   • NPM Package: has not been deprecated
   • Config Schema JSON: exists and is valid JSON
   • Config Schema JSON: contains a valid pluginAlias
   • Config Schema JSON: the pluginType is set to 'platform'
   • Dependencies: homebridge was not installed as a dependency
   • Dependencies: hap-nodejs was not installed as a dependency

   ---

   ⚠️ Please action these failures and then comment /check to run the checks again. Let us know if you need any help.

   If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.
3. github-actions

   added

   awaiting-changesuse after review has started - awaiting user to make changes to pluginuse after review has started - awaiting user to make changes to plugin

   and removed

   pendingthe label given to a new verification/icon requestthe label given to a new verification/icon request

   on Sep 15, 2024
4. rhockenbury commented on Sep 15, 2024

   

   rhockenbury

   on Sep 15, 2024

   Author

   More actions

   /check
5. github-actions

   added

   pendingthe label given to a new verification/icon requestthe label given to a new verification/icon request

   and removed

   awaiting-changesuse after review has started - awaiting user to make changes to pluginuse after review has started - awaiting user to make changes to plugin

   on Sep 15, 2024
6. github-actions commented on Sep 15, 2024

   

   github-actionsBot

   on Sep 15, 2024 – with GitHub Actions

   Contributor

   More actions

   🟢 The following checks passed:

   • Installation: successfully installed
   • Package JSON: homepage exists
   • Package JSON: bugs.url exists and seems a valid URL
   • Package JSON: keywords exist and contain 'homebridge-plugin'
   • Package JSON: 'preinstall' in scripts is not present
   • Package JSON: 'install' in scripts is not present
   • Package JSON: 'postinstall' in scripts is not present
   • Package JSON: engines.node property is compatible with Node 18
   • Package JSON: engines.node property is compatible with Node 20
   • Package JSON: engines.homebridge property is compatible with Homebridge 1.8.4
   • Package JSON: initializer function found
   • GitHub Repo: repository is public
   • GitHub Repo: repository is not archived
   • GitHub Repo: issues are enabled
   • GitHub Repo: contains releases
   • NPM Package: has not been deprecated
   • Config Schema JSON: exists and is valid JSON
   • Config Schema JSON: contains a valid pluginAlias
   • Config Schema JSON: the pluginType is set to 'platform'
   • Config Schema JSON: contains a name schema property
   • Dependencies: homebridge was not installed as a dependency
   • Dependencies: hap-nodejs was not installed as a dependency

   ---

   🎉 All checks passed successfully, nice work! Your plugin and/or icon will now be manually reviewed by the Homebridge team.
7. bwp91

   added

   currently-reviewinguse for starting a review - adds a comment with the verification list with empty checkboxesuse for starting a review - adds a comment with the verification list with empty checkboxes

   and removed

   pendingthe label given to a new verification/icon requestthe label given to a new verification/icon request

   on Sep 22, 2024
8. github-actions commented on Sep 22, 2024

   

   github-actionsBot

   on Sep 22, 2024 – with GitHub Actions

   Last edited by bwp91

   Contributor

   More actions

   • General
     • The plugin must be of type dynamic platform.
     • The plugin must not offer the same nor less functionality than that of any existing verified plugin.
   • Repo
     • The plugin must be published to NPM and the source code available on a GitHub repository, with issues enabled.
     • A GitHub release should be created for every new version of your plugin, with release notes.
   • Environment
     • The plugin must run on all supported LTS versions of Node.js, at the time of writing this is Node v18 and v20.
     • The plugin must successfully install and not start unless it is configured.
     • The plugin must not execute post-install scripts that modify the users' system in any way.
     • The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
   • Codebase
     • The plugin must implement the Homebridge Plugin Settings GUI.
     • The plugin must not contain any analytics or calls that enable you to track the user.
     • If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.
     • The plugin must not throw unhandled exceptions, the plugin must catch and log its own errors.
9. bwp91

   added

   verifieduse when a plugin meets the criteria - adds the verified badge textuse when a plugin meets the criteria - adds the verified badge text

   and removed

   currently-reviewinguse for starting a review - adds a comment with the verification list with empty checkboxesuse for starting a review - adds a comment with the verification list with empty checkboxes

   on Sep 22, 2024
10. github-actions commented on Sep 22, 2024

    

    github-actionsBot

    on Sep 22, 2024 – with GitHub Actions

    Contributor

    More actions

    Congratulations! Your plugin has been verified!

    You can now add one of the Verified by Homebridge badges to your plugin's README:

    

    [![verified-by-homebridge](https://badgen.net/badge/homebridge/verified/purple)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)
    

    

    [![verified-by-homebridge](https://img.shields.io/badge/homebridge-verified-blueviolet?color=%23491F59&style=for-the-badge&logoColor=%23FFFFFF&logo=homebridge)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)
    

    Your plugin is now also eligible to display a ❤️ Donate button on its tile in the Homebridge UI. See https://github.com/homebridge/homebridge/wiki/Donation-Links for instructions.

    If for any reason in the future you can no longer maintain your plugin, please consider transferring it to our unmaintained plugins repo. We can take ownership until another willing developer comes along.

    Don't forget to join the official Homebridge Discord server, where plugin developers can get tips and advice from other developers and the Homebridge project team in the #plugin-development channel!

    As a verified plugin, you can request a channel in the Discord server to discuss your plugin with users and other developers. Just ask in the #plugin-development channel.

    Thank you for your contribution to the Homebridge community.

    • The Homebridge Team
11. bwp91 commented on Sep 22, 2024

    

    bwp91

    on Sep 22, 2024

    Contributor

    More actions

    The only thing I noticed from the logging of my default config:

    

    ...was that some of the booleans appear wrapped in quotes so they are strings. I haven't checked your code, but my initial thought was that maybe if you are testing something like if (staticNames) then this might evaluate to true instead of false
12. bwp91

    added a commit that references this issue on Sep 22, 2024

    verify: homebridge-ecowitt-weather-sensors

    ...

    c2daf24
13. bwp91

    closed this as completedon Sep 22, 2024
14. rhockenbury commented on Sep 22, 2024

    

    rhockenbury

    on Sep 22, 2024

    Author

    More actions

    Hi @bwp91. Thanks! For the plugin to show as verified through the homebridge UI, would I need to publish a new version of the plugin? Just checked, and didn't see it showing up as verified, even after uninstalling and searching for it fresh.
15. bwp91 commented on Sep 22, 2024

    

    bwp91

    on Sep 22, 2024

    Contributor

    More actions

    You don't need to publish a new version, the UI grabs and caches the verified plugin list every 12 hours, so it could take up to this time to reflect new plugins.

    https://github.com/homebridge/homebridge-config-ui-x/blob/4d1e79886d643b9911f9c8ca950972ae1f609aa4/src/modules/plugins/plugins.service.ts#L131

    You may be able to force refresh the list by using the "Restart HB Service & UI" option to restart.

    👍React with 👍1Reacted by Ryler Hockenbury