Skip to content

Verification Request: homebridge-smartrent #858

New issue
New issue
Closed
Closed
Verification Request: homebridge-smartrent#858
Labels
request-verificationverifieduse when a plugin meets the criteria - adds the verified badge text

Description

@BitWise-0x
BitWise-0x
opened on Aug 6, 2025

Plugin Name

@jackietreeh0rn/homebridge-smartrent

Link To GitHub Repo

https://github.com/JackieTreeh0rn/homebridge-smartrent

Plugin Icon (Optional)

No response

The plugin does not offer the same nor less functionality than that of any existing verified plugin.

🟢 Yes

The plugin successfully installs and does not start unless it is configured.

🟢 Yes

The plugin does not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.

🟢 Yes

The plugin does not contain any analytics or calls that enable you to track the user.

🟢 Yes

If the plugin needs to write files to disk (cache, keys, etc.), it stores them inside the Homebridge storage directory.

🟢 Yes

The plugin does not throw unhandled exceptions, the plugin must catch and log its own errors.

🟢 Yes

More Information

No response

Activity

  1. BitWise-0x
    added
    pendingthe label given to a new verification/icon request
    request-verification
    on Aug 6, 2025

  2. github-actions commented on Aug 6, 2025

    @github-actions
    github-actionsBot
    on Aug 6, 2025 – with GitHub Actions
    Contributor

    🔴 The following checks failed:

    • Config Schema JSON: does not contain a name schema property

    🟢 The following checks passed:

    • Installation: successfully installed
    • Package JSON: homepage exists
    • Package JSON: bugs.url exists and seems a valid URL
    • Package JSON: keywords exist and contain 'homebridge-plugin'
    • Package JSON: 'preinstall' in scripts is not present
    • Package JSON: 'install' in scripts is not present
    • Package JSON: 'postinstall' in scripts is not present
    • Package JSON: engines.node property is compatible with Node 20
    • Package JSON: engines.node property is compatible with Node 22
    • Package JSON: engines.homebridge property is compatible with Homebridge 1.11.0
    • Package JSON: initializer function found
    • GitHub Repo: repository is public
    • GitHub Repo: repository is not archived
    • GitHub Repo: issues are enabled
    • GitHub Repo: contains releases
    • NPM Package: has not been deprecated
    • Config Schema JSON: exists and is valid JSON
    • Config Schema JSON: contains a valid pluginAlias
    • Config Schema JSON: the pluginType is set to 'platform'
    • Dependencies: homebridge was not installed as a dependency
    • Dependencies: hap-nodejs was not installed as a dependency

    ⚠️ Please action these failures and then comment /check to run the checks again. Let us know if you need any help.

    If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.

    These checks were run against v1.0.5 of the plugin.

  3. github-actions
    added
    awaiting-changesuse after review has started - awaiting user to make changes to plugin
    and removed
    pendingthe label given to a new verification/icon request
    on Aug 6, 2025

  4. BitWise-0x commented on Aug 6, 2025

    @BitWise-0x
    BitWise-0x
    on Aug 6, 2025
    Author

    /check

  5. github-actions
    added
    pendingthe label given to a new verification/icon request
    and removed
    awaiting-changesuse after review has started - awaiting user to make changes to plugin
    on Aug 6, 2025

  6. github-actions commented on Aug 6, 2025

    @github-actions
    github-actionsBot
    on Aug 6, 2025 – with GitHub Actions
    Contributor

    🟢 The following checks passed:

    • Installation: successfully installed
    • Package JSON: homepage exists
    • Package JSON: bugs.url exists and seems a valid URL
    • Package JSON: keywords exist and contain 'homebridge-plugin'
    • Package JSON: 'preinstall' in scripts is not present
    • Package JSON: 'install' in scripts is not present
    • Package JSON: 'postinstall' in scripts is not present
    • Package JSON: engines.node property is compatible with Node 20
    • Package JSON: engines.node property is compatible with Node 22
    • Package JSON: engines.homebridge property is compatible with Homebridge 1.11.0
    • Package JSON: initializer function found
    • GitHub Repo: repository is public
    • GitHub Repo: repository is not archived
    • GitHub Repo: issues are enabled
    • GitHub Repo: contains releases
    • NPM Package: has not been deprecated
    • Config Schema JSON: exists and is valid JSON
    • Config Schema JSON: contains a valid pluginAlias
    • Config Schema JSON: the pluginType is set to 'platform'
    • Config Schema JSON: contains a name schema property
    • Dependencies: homebridge was not installed as a dependency
    • Dependencies: hap-nodejs was not installed as a dependency

    🎉 All checks passed successfully, nice work! Your plugin and/or icon will now be manually reviewed by the Homebridge team.

    These checks were run against v1.0.6 of the plugin.

  7. BitWise-0x commented on Aug 20, 2025

    @BitWise-0x
    BitWise-0x
    on Aug 20, 2025
    Author

    is there a follow-on process for verification?

  8. bwp91 commented on Aug 30, 2025

    @bwp91
    bwp91
    on Aug 30, 2025
    Contributor

    /check

  9. github-actions commented on Aug 30, 2025

    @github-actions
    github-actionsBot
    on Aug 30, 2025 – with GitHub Actions
    Contributor

    🟢 The following checks passed:

    • Installation: successfully installed
    • Package JSON: homepage exists
    • Package JSON: bugs.url exists and seems a valid URL
    • Package JSON: keywords exist and contain 'homebridge-plugin'
    • Package JSON: 'preinstall' in scripts is not present
    • Package JSON: 'install' in scripts is not present
    • Package JSON: 'postinstall' in scripts is not present
    • Package JSON: engines.node property is compatible with Node 20
    • Package JSON: engines.node property is compatible with Node 22
    • Package JSON: engines.homebridge property is compatible with Homebridge 1.11.0
    • Package JSON: initializer function found
    • NPM Package: has not been deprecated
    • Config Schema JSON: exists and is valid JSON
    • Config Schema JSON: contains a valid pluginAlias
    • Config Schema JSON: the pluginType is set to 'platform'
    • Config Schema JSON: contains a name schema property
    • Dependencies: homebridge was not installed as a dependency
    • Dependencies: hap-nodejs was not installed as a dependency
    • Runtime: homebridge installed successfully
    • Runtime: no config - homebridge should start without plugin configuration
    • Runtime: platform only - plugin should start with just platform property
    • Runtime: minimal required - plugin should start with minimal required configuration
    • Runtime: full config - plugin should start with comprehensive configuration
    • Runtime: network resilience - plugin should handle network failures without crashing
    • GitHub Repo: repository is public
    • GitHub Repo: repository is not archived
    • GitHub Repo: issues are enabled
    • GitHub Repo: contains releases

    🎉 All checks passed successfully, nice work! Your plugin and/or icon will now be manually reviewed by the Homebridge team.

    These checks were run against v1.0.8 of the plugin.

  10. bwp91 commented on Aug 30, 2025

    @bwp91
    bwp91
    on Aug 30, 2025
    Contributor

    @JackieTreeh0rn whilst the test script was running on this plugin, it tries different configs and starts the plugin for about 30 seconds. it also collects up any http requests it makes to urls and the counts.

    your plugin made requests to these urls

    🌐 HTTP Requests Summary:
==================================================
📡 [https://control.smartrent.com:443/socket/websocket?token=undefined&vsn=2.0.0](https://control.smartrent.com/socket/websocket?token=undefined&vsn=2.0.0)
   Methods: GET | Count: 513 | Scenarios: platform only, minimal required, full config
📡 https://control.smartrent.com/authentication/sessions
   Methods: POST | Count: 327 | Scenarios: minimal required, full config, network resilience

📊 Total: 840 requests to 2 unique URLs

    it just surprised me the number of requests that were made in the very small amount of time that the plugin was running. are you aware of this? could this be reduced at all?

  11. bwp91
    added
    awaiting-user-replyuse after review has started - awaiting user to reply to a comment
    and removed
    pendingthe label given to a new verification/icon request
    on Aug 30, 2025

  12. 5 remaining items

  13. github-actions commented on Aug 30, 2025

    @github-actions
    github-actionsBot
    on Aug 30, 2025 – with GitHub Actions
    Contributor

    🔴 The following checks failed:

    Runtime Configuration Issues:

    • platform only: Plugin crashes when started with the following configuration:
    {
  "platform": "SmartRent"
}

    Error:

    expected startup but failed - [8/30/2025, 11:41:46 PM] Error: Authentication failed: No access token for WebSocket
    at SmartRentWebsocketClient._initializeWsClient (file:///workspace/test-area/node_modules/@jackietreeh0rn/homebridge-smartrent/src/lib/client.ts:205:13)

    ⚠️ This needs to be fixed so that the plugin does not crash when started with this configuration. The plugin should either:

    • Handle missing required configuration gracefully with proper error messages

    • Provide sensible defaults for missing values

    • Validate configuration during startup and log helpful warnings

    • minimal required: Plugin crashes when started with the following configuration:

    {
  "platform": "SmartRent",
  "email": "testvalue",
  "password": "testvalue"
}

    Error:

    expected startup but failed - [8/30/2025, 11:41:52 PM] Error: Authentication failed: No access token for WebSocket
    at SmartRentWebsocketClient._initializeWsClient (file:///workspace/test-area/node_modules/@jackietreeh0rn/homebridge-smartrent/src/lib/client.ts:205:13)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)

    ⚠️ This needs to be fixed so that the plugin does not crash when started with this configuration. The plugin should either:

    • Handle missing required configuration gracefully with proper error messages

    • Provide sensible defaults for missing values

    • Validate configuration during startup and log helpful warnings

    • full config: Plugin crashes when started with the following configuration:

    {
  "platform": "SmartRent",
  "name": "SmartRent",
  "email": "test@example.com",
  "password": "testpassword",
  "tfaSecret": "test-value0123456789abcdef012345",
  "enableLeakSensors": true,
  "enableThermostats": true,
  "enableLocks": true,
  "enableSwitches": true,
  "enableSwitchMultiLevels": true,
  "unitName": "test-value",
  "enableAutoLock": false,
  "autoLockDelayInMinutes": 5
}

    Error:

    expected startup but failed - [8/30/2025, 11:41:59 PM] Error: Authentication failed: No access token for WebSocket
    at SmartRentWebsocketClient._initializeWsClient (file:///workspace/test-area/node_modules/@jackietreeh0rn/homebridge-smartrent/src/lib/client.ts:205:13)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)

    ⚠️ This needs to be fixed so that the plugin does not crash when started with this configuration. The plugin should either:

    • Handle missing required configuration gracefully with proper error messages
    • Provide sensible defaults for missing values
    • Validate configuration during startup and log helpful warnings

    🟢 The following checks passed:

    • Installation: successfully installed
    • Package JSON: homepage exists
    • Package JSON: bugs.url exists and seems a valid URL
    • Package JSON: keywords exist and contain 'homebridge-plugin'
    • Package JSON: 'preinstall' in scripts is not present
    • Package JSON: 'install' in scripts is not present
    • Package JSON: 'postinstall' in scripts is not present
    • Package JSON: engines.node property is compatible with Node 20
    • Package JSON: engines.node property is compatible with Node 22
    • Package JSON: engines.homebridge property is compatible with Homebridge 1.11.0
    • Package JSON: initializer function found
    • NPM Package: has not been deprecated
    • Config Schema JSON: exists and is valid JSON
    • Config Schema JSON: contains a valid pluginAlias
    • Config Schema JSON: the pluginType is set to 'platform'
    • Config Schema JSON: contains a name schema property
    • Dependencies: homebridge was not installed as a dependency
    • Dependencies: hap-nodejs was not installed as a dependency
    • Runtime: homebridge installed successfully
    • Runtime: no config - homebridge should start without plugin configuration and plugin should not load
    • Runtime: network resilience - plugin should handle network failures without crashing
    • GitHub Repo: repository is public
    • GitHub Repo: repository is not archived
    • GitHub Repo: issues are enabled
    • GitHub Repo: contains releases

    ⚠️ Please action these failures and then comment /check to run the checks again. Let us know if you need any help.

    If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.

    These checks were run against v1.0.9 of the plugin.

  14. github-actions
    added
    awaiting-changesuse after review has started - awaiting user to make changes to plugin
    and removed
    pendingthe label given to a new verification/icon request
    on Aug 30, 2025

  15. BitWise-0x commented on Aug 30, 2025

    @BitWise-0x
    BitWise-0x
    on Aug 30, 2025
    Author

    ...looks like my token checks were too draconian and halted connectivity in absence-of altogether. working it... 👀

  16. BitWise-0x commented on Aug 31, 2025

    @BitWise-0x
    BitWise-0x
    on Aug 31, 2025
    Author

    /check

  17. github-actions
    added
    pendingthe label given to a new verification/icon request
    and removed
    awaiting-changesuse after review has started - awaiting user to make changes to plugin
    on Aug 31, 2025

  18. github-actions commented on Aug 31, 2025

    @github-actions
    github-actionsBot
    on Aug 31, 2025 – with GitHub Actions
    Contributor

    🟢 The following checks passed:

    • Installation: successfully installed
    • Package JSON: homepage exists
    • Package JSON: bugs.url exists and seems a valid URL
    • Package JSON: keywords exist and contain 'homebridge-plugin'
    • Package JSON: 'preinstall' in scripts is not present
    • Package JSON: 'install' in scripts is not present
    • Package JSON: 'postinstall' in scripts is not present
    • Package JSON: engines.node property is compatible with Node 20
    • Package JSON: engines.node property is compatible with Node 22
    • Package JSON: engines.homebridge property is compatible with Homebridge 1.11.0
    • Package JSON: initializer function found
    • NPM Package: has not been deprecated
    • Config Schema JSON: exists and is valid JSON
    • Config Schema JSON: contains a valid pluginAlias
    • Config Schema JSON: the pluginType is set to 'platform'
    • Config Schema JSON: contains a name schema property
    • Dependencies: homebridge was not installed as a dependency
    • Dependencies: hap-nodejs was not installed as a dependency
    • Runtime: homebridge installed successfully
    • Runtime: no config - homebridge should start without plugin configuration and plugin should not load
    • Runtime: platform only - plugin should start with just platform property
    • Runtime: minimal required - plugin should start with minimal required configuration
    • Runtime: full config - plugin should start with comprehensive configuration
    • Runtime: network resilience - plugin should handle network failures without crashing
    • GitHub Repo: repository is public
    • GitHub Repo: repository is not archived
    • GitHub Repo: issues are enabled
    • GitHub Repo: contains releases

    🎉 All checks passed successfully, nice work! Your plugin and/or icon will now be manually reviewed by the Homebridge team.

    These checks were run against v1.0.10 of the plugin.

  19. BitWise-0x commented on Aug 31, 2025

    @BitWise-0x
    BitWise-0x
    on Aug 31, 2025
    Author

    @bwp91 ok, it should be good now 😇

  20. bwp91
    added a commit that references this issue on Aug 31, 2025

    verify: @jackietreeh0rn/homebridge-smartrent

    9afec0b
  21. bwp91
    added
    verifieduse when a plugin meets the criteria - adds the verified badge text
    and removed
    pendingthe label given to a new verification/icon request
    on Aug 31, 2025

  22. github-actions commented on Aug 31, 2025

    @github-actions
    github-actionsBot
    on Aug 31, 2025 – with GitHub Actions
    Contributor

    Congratulations! Your plugin has been verified!

    You can now add one of the Verified by Homebridge badges to your plugin's README:

    verified-by-homebridge

    [![verified-by-homebridge](https://badgen.net/badge/homebridge/verified/purple)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

    verified-by-homebridge

    [![verified-by-homebridge](https://img.shields.io/badge/homebridge-verified-blueviolet?color=%23491F59&style=for-the-badge&logoColor=%23FFFFFF&logo=homebridge)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

    Your plugin is now also eligible to display a ❤️ Donate button on its tile in the Homebridge UI. See https://github.com/homebridge/homebridge/wiki/Donation-Links for instructions.

    Interested in getting a @homebridge-plugins/ scope for your plugin? See our Homebridge Scoped Plugins program.

    If for any reason in the future you can no longer maintain your plugin, please consider transferring it to our Homebridge Plugins organization.

    Don't forget to join the official Homebridge Discord server, where plugin developers can get tips and advice from other developers and the Homebridge project team in the #plugin-development channel!

    As a verified plugin, you can request a channel in the Discord server to discuss your plugin with users and other developers. Just ask in the #plugin-development channel.

    Thank you for your contribution to the Homebridge community.

    • The Homebridge Team

  23. bwp91 commented on Aug 31, 2025

    @bwp91
    bwp91
    on Aug 31, 2025
    Contributor

    all good now 🙂 thanks for making those changes!

  24. bwp91
    closed this as completedon Aug 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    request-verificationverifieduse when a plugin meets the criteria - adds the verified badge text

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions