D3D11: Always use accurate depth#12836
Merged
hrydgard merged 2 commits intohrydgard:masterfrom Apr 19, 2020
Merged
Conversation
If we flip this because of frameskip, we need to actually process.
The Direct3D APIs use a "min" and "max" value, and it's required that min must be less than or equal to max. If this requirement is not met, the viewport parameters are not updated. We forced accurate depth on for NVIDIA and AMD, but this just meant Intel was still broken and less people were reporting bugs about it. Although the PSP GE has depth viewport transform, this is not used for clipping and is not actually the depth range. The minz and maxz GE registers are the depth range, and minz must be less than or equal to maxz for drawing to occur.
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Direct3D APIs use a "min" and "max" value, and it's required that min must be less than or equal to max. If this requirement is not met, the viewport parameters are not updated.
I think we assumed this was at a driver level and forced accurate depth on for NVIDIA and AMD, but this just meant Intel was still broken and less people were reporting bugs about it.
Although the PSP GE has depth viewport transform, this is not used for clipping and is not actually the depth range. The minz and maxz GE registers are the depth range, and minz must be less than or equal to maxz for drawing to occur. It's just that it also uses depth clamping.
Fixes #12831.
-[Unknown]