Request::body_json should return 4xx error if body can not be deserialized

[jhorstmann]

Currently the body_json function returns a std::io::Result, which gets converted into a 500 status code later. While this is probably ok for actual io errors, any errors happening during parsing of the json bytes are more likely caused by incorrect data being send by the client and so should result in a 400 Bad Request status code.

See

tide/src/request.rs

Line 266 in 999c30c

Ok(serde_json::from_slice(&body_bytes).map_err(|_| std::io::ErrorKind::InvalidData)?)

[vkill]

@jhorstmann You can use status to custom it in your app.

use tide::Status;

let body = serde_json::from_slice(&body_bytes).status(400)?

By default, any error is 500 , you can submit a PR to match error kind.

[jannik4]

This should be fixed since #537, so I think this can be closed.