Merged
Conversation
yoshuawuyts
force-pushed
the
remove-http-service
branch
from
8fe0295 to
b45bf6b
Compare
jbr
approved these changes
May 15, 2020
Member
jbr
left a comment
jbr
left a comment
There was a problem hiding this comment.
It's really cool that so little new code was needed to replace http-service 👍
My only real concern is with error handling. I need to check back on the details, but I believe the spec has notions of what type of responses must be sent back for different types of errors that occur within async-h1 that we're currently squishing into an Other io::Error.
One approach to this might be for a request to have a way of attaching an http-level error to it so that some sort of default middleware can figure out how to respond to it?
connec
reviewed
May 15, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #501. Removes all of our use of
http-service, simplifying our tests significantly. This sets us up to use Surf for our request instantiation in the future as well. Thanks!