set local and peer addrs in tide#530
Merged
yoshuawuyts merged 2 commits intohttp-rs:masterfrom May 23, 2020
Merged
Conversation
jbr
force-pushed
the
populate-local-and-peer-addrs
branch
from
0ec656a to
3e2e84c
Compare
dignifiedquire
approved these changes
May 23, 2020
Member
dignifiedquire
left a comment
dignifiedquire
left a comment
There was a problem hiding this comment.
maybe we could have a test?
yoshuawuyts
approved these changes
May 23, 2020
jbr
force-pushed
the
populate-local-and-peer-addrs
branch
from
18d1720 to
d364a95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
forgot to pr this before 0.9, sorry!