Skip to content

return a result from sse sender#598

Merged
jbr merged 1 commit intohttp-rs:masterfrom
jbr:handle-dropped-sse-encoder
Jul 7, 2020
Merged

return a result from sse sender#598
jbr merged 1 commit intohttp-rs:masterfrom
jbr:handle-dropped-sse-encoder

Conversation

@jbr
Copy link
Member

@jbr jbr commented Jun 15, 2020

in order to allow endpoints to break out of loops

dependent on: http-rs/async-sse#3

closes #591

@jbr jbr requested a review from yoshuawuyts June 15, 2020 03:54
@jbr jbr force-pushed the handle-dropped-sse-encoder branch from b233a66 to 276c5ef Compare June 15, 2020 03:56
@jbr jbr added bug Something isn't working blocked An issue that's blocked on upstream changes labels Jun 19, 2020
@jbr
Copy link
Member Author

jbr commented Jun 25, 2020

This is now blocked on an async-sse release (which I think is a major release because this changes the api)

@jbr jbr removed the blocked An issue that's blocked on upstream changes label Jul 7, 2020
in order to allow endpoints to break out of loops
@jbr jbr force-pushed the handle-dropped-sse-encoder branch from 276c5ef to 88b0cbb Compare July 7, 2020 21:24
@jbr
Copy link
Member Author

jbr commented Jul 7, 2020

Merging this because async-sse 3.0.1 was published, breaking tide master (and tide 0.11). We'll probably want to yank async-sse 3.0.1 and republish as 4.0.0, which will require bumping tide's dep on master to async-sse 4.0.0, but merging this will fix tide master CI

@jbr jbr merged commit 2c82985 into http-rs:master Jul 7, 2020
@yoshuawuyts
Copy link
Member

@jbr thanks for catching that and running the release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSE handler never dropped

2 participants