Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ kv-log-macro = "1.0.4"
serde = "1.0.102"
serde_json = "1.0.41"
route-recognizer = "0.2.0"
logtest = "2.0.0"

[dev-dependencies]
async-std = { version = "1.6.0", features = ["unstable", "attributes"] }
Expand Down
10 changes: 3 additions & 7 deletions src/server.rs
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ impl<State: Send + Sync + 'static> Server<State> {
} else {
"release"
};
log::info!("Server listening", { address: addr, target: target, tls: tls });
log::info!("Server listening on {}", addr, { address: addr, target: target, tls: tls });

let mut incoming = listener.incoming();
while let Some(stream) = incoming.next().await {
Expand Down Expand Up @@ -341,12 +341,8 @@ impl<State: Send + Sync + 'static> Server<State> {
"release"
};

let address = listener
.local_addr()
.ok()
.map(|addr| format!("unix://{:?}", addr));

log::info!("Server listening", { address: address, target: target, tls: tls });
let addr = format!("unix://{:?}", listener.local_addr()?);
log::info!("Server listening on {}", addr, { address: addr, target: target, tls: tls });

let mut incoming = listener.incoming();
while let Some(stream) = incoming.next().await {
Expand Down
26 changes: 26 additions & 0 deletions tests/log.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
use async_std::prelude::*;
use std::time::Duration;

mod test_utils;

#[async_std::test]
async fn start_server_log() {
let logger = logtest::start();

let port = test_utils::find_port().await;
let app = tide::new();
let res = app
.listen(("localhost", port))
.timeout(Duration::from_millis(60))
.await;
assert!(res.is_err());

let record = logger
.filter(|rec| rec.args().starts_with("Server listening"))
.next()
.unwrap();
assert_eq!(
record.args(),
format!("Server listening on http://[::1]:{}", port)
);
}