Make ServeDir return 404 if file does not exists#637
Merged
yoshuawuyts merged 5 commits intohttp-rs:masterfrom Jul 10, 2020
pbzweihander:servedir-404
Merged
Make ServeDir return 404 if file does not exists#637yoshuawuyts merged 5 commits intohttp-rs:masterfrom pbzweihander:servedir-404
ServeDir return 404 if file does not exists#637yoshuawuyts merged 5 commits intohttp-rs:masterfrom
pbzweihander:servedir-404
Conversation
yoshuawuyts
approved these changes
Jul 10, 2020
Member
yoshuawuyts
left a comment
There was a problem hiding this comment.
@pbzweihander Thanks so much for this PR; these changes are great! -- a few nits aside I think we can merge this!
yoshuawuyts
reviewed
Jul 10, 2020
yoshuawuyts
reviewed
Jul 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make
ServeDirreturn404 Not Foundresponse when the requested file does not exist.Motivation and Context
ServeDir, the internal static file serving endpoint, returns 500 when the file does not exist. But I expected 404.How Has This Been Tested?
ServeDirdid not have any test, so I added some unit tests that call thecallmethod directly and some integration tests that request toServeDirusingRoute::serve_dir.Unfortunately, I could not find any test case to produce a
401 Forbiddenerror. Thehttp_types::Urltype seems to normalize the path segments so I couldn't produce any URL path that refers outside of the desired directory.Types of changes
Checklist: