Skip to content

enable clippy for tests#655

Merged
jbr merged 1 commit intohttp-rs:masterfrom
ririsoft:quality
Jul 21, 2020
Merged

enable clippy for tests#655
jbr merged 1 commit intohttp-rs:masterfrom
ririsoft:quality

Conversation

@ririsoft
Copy link
Contributor

This PR enables clippy checks for tests and examples during CI.

Description

Clippy is valuable for tests and examples too, it can spot some mistakes that would make a test wrong.

Motivation and Context

Having zero Clippy errors after the first clone/fork improves the contributor experience.

How Has This Been Tested?

cargo test --all --features unstable
cargo clippy --tests --examples

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Clippy is valuable for tests too.
Copy link
Member

@jbr jbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jbr
Copy link
Member

jbr commented Jul 21, 2020

Thanks!

@jbr jbr merged commit ae0e532 into http-rs:master Jul 21, 2020
Fishrock123 added a commit to Fishrock123/surf that referenced this pull request Jul 21, 2020
Fishrock123 added a commit to Fishrock123/surf that referenced this pull request Jul 21, 2020
@ririsoft ririsoft deleted the quality branch July 22, 2020 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants