Merged
Conversation
Clippy is valuable for tests too.
Member
|
Thanks! |
Fishrock123
added a commit
to Fishrock123/surf
that referenced
this pull request
Jul 21, 2020
Fishrock123
added a commit
to Fishrock123/surf
that referenced
this pull request
Jul 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables clippy checks for tests and examples during CI.
Description
Clippy is valuable for tests and examples too, it can spot some mistakes that would make a test wrong.
Motivation and Context
Having zero Clippy errors after the first clone/fork improves the contributor experience.
How Has This Been Tested?
cargo test --all --features unstablecargo clippy --tests --examplesTypes of changes
Checklist: