log: display client error messages when possible as warnings#691
Merged
Fishrock123 merged 2 commits intohttp-rs:mainfrom Sep 3, 2020
Merged
log: display client error messages when possible as warnings#691Fishrock123 merged 2 commits intohttp-rs:mainfrom
Fishrock123 merged 2 commits intohttp-rs:mainfrom
Conversation
This should help demystify some cases when client errors are determined by parsing and propagated via `?`.
This should help the default logger be as helpful as possible.
fa1f3b7 to
b373610
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should help demystify some cases when client errors are determined by parsing and propagated via
?.Description
Makes the logger display an associated error message when this warning occurs, if possible.
Also clarified that a client error occured.
Motivation and Context
For never users some cases of client errors being caused by e.g. body parsing and then propgated via
?may be unobvious. This helps demystify that.How Has This Been Tested?
Manual curl to the json example. Output:
Checklist: